From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Preetham Chandru Ramchandra <pchandru@nvidia.com>
Cc: thierry.reding@gmail.com, tj@kernel.org, cyndis@kapsi.fi,
preetham260@gmail.com, linux-tegra@vger.kernel.org,
linux-ide@vger.kernel.org, vbyravarasu@nvidia.com,
pkunapuli@nvidia.com
Subject: Re: [PATCH V5 1/3] ata: ahci_tegra: Add AHCI support for tegra210
Date: Tue, 18 Jul 2017 18:16:25 +0200 [thread overview]
Message-ID: <2330130.R7nNpdRms5@amdc3058> (raw)
In-Reply-To: <1498830993-24666-2-git-send-email-pchandru@nvidia.com>
Hi,
On Friday, June 30, 2017 07:26:31 PM Preetham Chandru Ramchandra wrote:
> From: Preetham Chandru R <pchandru@nvidia.com>
>
> 1. Move tegra124 specifics to tegra124_ahci_init.
> 2. Separate the regulators needed for tegra124 and tegra210.
> 3. Disable DIPM for t210 and t124 as there are known issues.
> 4. Disable Devslp for t210 since devslp pin is shared with
> pcie clkreq.
>
> Signed-off-by: Preetham Chandru R <pchandru@nvidia.com>
Please consider splitting this combined patch on smaller logical
parts (adding new initialization code used on both chipsets to
tegra_ahci_controller_init() should be done in preparatory
patch before adding T210 support, same for addition of NO_DIPM
flag) to ease the review, potential handling of regressions and
backporting of fixes to older kernels. The code changes itself
look good to me.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2017-07-18 16:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 13:56 [PATCH V5 0/3] ADD AHCI support for tegra210 Preetham Chandru Ramchandra
2017-06-30 13:56 ` [PATCH V5 2/3] arm64: tegra: Enable AHCI on Tegra210 Preetham Chandru Ramchandra
2017-07-17 14:56 ` Mikko Perttunen
[not found] ` <1498830993-24666-1-git-send-email-pchandru-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-06-30 13:56 ` [PATCH V5 1/3] ata: ahci_tegra: Add AHCI support for tegra210 Preetham Chandru Ramchandra
[not found] ` <1498830993-24666-2-git-send-email-pchandru-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-07-17 14:56 ` Mikko Perttunen
[not found] ` <CGME20170718161627epcas5p16d97b0c718cc9ba1fa7483a727f6c2a3@epcas5p1.samsung.com>
2017-07-18 16:16 ` Bartlomiej Zolnierkiewicz [this message]
2017-06-30 13:56 ` [PATCH V5 3/3] dt-bindings: tegra: add binding documentation Preetham Chandru Ramchandra
[not found] ` <1498830993-24666-4-git-send-email-pchandru-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-07-17 15:08 ` Mikko Perttunen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2330130.R7nNpdRms5@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=cyndis@kapsi.fi \
--cc=linux-ide@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pchandru@nvidia.com \
--cc=pkunapuli@nvidia.com \
--cc=preetham260@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=tj@kernel.org \
--cc=vbyravarasu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).