Re: [PATCH] ata: libata-core: Fix ata_pci_shutdown_one()

[Damien Le Moal <dlemoal@kernel.org>]

On 11/6/23 17:47, Sergey Shtylyov wrote:
> Hello!
> 
> On 11/6/23 7:16 AM, Damien Le Moal wrote:
> 
>> Commit 5b6fba546da2 ("ata: libata-core: Detach a port devices on
>> shutdown") modified the function ata_pci_shutdown_one() to stop
>> (suspend) devices attached to the ports of a PCI AHCI adapter to ensure
>> that drives are spun down before shutting down a system. However, this
>> is done only for PCI adapters and not for other types of adapters. This
>> limitation was addressed with commit 24eca2dce0f8 ("scsi: sd: Introduce
>> manage_shutdown device flag"). With this, all ATA disks are spun down on
>> system shutdown.
>>
>> This reverts commit 5b6fba546da2 as the change introduced is now
>> useless.
> 
>    You didn't use 'git revert'?

I did, but I wrote a proper commit message.

> 
>> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> [...]
> 
> MBR, Sergey

-- 
Damien Le Moal
Western Digital Research