From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 2/2] ide-generic: added messages in case of PCI IDE devices Date: Tue, 28 Feb 2017 13:32:38 +0100 Message-ID: <2394462.3yLrzL1TEf@amdc3058> References: <20170221142249.GC11234@giustizia> <20170222003831.GA14251@giustizia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Return-path: Received: from mailout1.samsung.com ([203.254.224.24]:59361 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752461AbdB1MoE (ORCPT ); Tue, 28 Feb 2017 07:44:04 -0500 Received: from epcas5p3.samsung.com (unknown [182.195.41.41]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OM30225646HGX10@mailout1.samsung.com> for linux-ide@vger.kernel.org; Tue, 28 Feb 2017 21:32:41 +0900 (KST) In-reply-to: <20170222003831.GA14251@giustizia> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Luiz Carlos Ramos Cc: Sergei Shtylyov , linux-ide@vger.kernel.org, David Miller , petkovbb@gmail.com On Tuesday, February 21, 2017 09:38:31 PM Luiz Carlos Ramos wrote: > Hello, Sergei! > > I have a question or two about checkpatch.pl results below. > > On Tue, Feb 21, 2017 at 06:52:13PM +0300, Sergei Shtylyov wrote: > > On 02/21/2017 05:22 PM, Luiz Carlos Ramos wrote: > > > > >Two messages are now displayed (at "warn" level) to make sure the user > > >is aware that PCI IDE devices were detected at common addresses (0x1f0 > > >and 0x170) and that they will not be managed by ide-generic, but rather > > >delegated to its specific driver. > > > > > >Signed-off-by: Luiz Carlos Ramos > > >--- > > > drivers/ide/ide-generic.c | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > >diff --git a/drivers/ide/ide-generic.c b/drivers/ide/ide-generic.c > > >index ee11edcdba3170c077381d603918498d79ffa3bb..2204819ef73612deed4ebfe58c69cdadb40fa53b 100644 > > >--- a/drivers/ide/ide-generic.c > > >+++ b/drivers/ide/ide-generic.c > > >@@ -125,9 +125,19 @@ static int __init ide_generic_init(void) > > > > > > if (primary == 0) > > > probe_mask |= 0x1; > > >+ else { > > >+ printk(KERN_WARN DRV_NAME ": PCI IDE device detected at 0x%4.4x." > > > > Also, please use pr_warn(). > > > > This code is quite old, and it is in deep maintenance phase. > > Every other message in ide-generic.c is implemented as printk(...), > but to be fair, there are not so many of them. > > Given that fact, would it be better to change these two ones to be > inserted to pr_warn() as suggested (and then having a mix of printk() > and pr_warn() in the code), or to "allow" two more printk() in the code > and having checkpatck.pl complaining? > > I really don't know what is better or worse. Both can be implemented, > and there are a mix of advantages and disadvantages in each side. > > I'd like to hear from you and colleagues about how to proceed. Well, I vote for allowing two more printk() and leaving the old code as it is. > > >+ " ide-generic will not grab this device, delegating it to" > > >+ " the driver of its specific chipset\n", 0x1f0); > > >+ } > > > > > > if (secondary == 0) > > > probe_mask |= 0x2; > > >+ else { > > >+ printk(KERN_WARN DRV_NAME ": PCI IDE device detected at 0x%4.4x." > > > > Likewise. > > > > >+ " ide-generic will not grab this device, delegating it to" > > >+ " the driver of its specific chipset\n", 0x170); > > >+ } > > > } else > > > printk(KERN_INFO DRV_NAME ": enforcing probing of I/O ports " > > > "upon user request\n"); > > > > MBR, Sergei > > > > Best regards, > > Luiz Carlos Ramos Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics