linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gabriele Mazzotta <gabriele.mzt@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: linux-ide@vger.kernel.org, tj@kernel.org, stripathi@apm.com
Subject: Re: SATA link power management issues
Date: Mon, 12 Jan 2015 15:05:01 -0800 (PST)	[thread overview]
Message-ID: <2526428.uJaEqCTeIa@xps13> (raw)
In-Reply-To: <3352987.ugV1Ipy7Z5@xps13>

I just tried the following and I no longer get errors:

diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index 97683e4..c815b31 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -1708,10 +1708,10 @@ static void ahci_handle_port_interrupt(struct ata_port *ap,
 		status &= ~PORT_IRQ_BAD_PMP;
 
 	/* if LPM is enabled, PHYRDY doesn't mean anything */
-	if (ap->link.lpm_policy > ATA_LPM_MAX_POWER) {
+//	if (ap->link.lpm_policy > ATA_LPM_MAX_POWER) {
 		status &= ~PORT_IRQ_PHYRDY;
 		ahci_scr_write(&ap->link, SCR_ERROR, SERR_PHYRDY_CHG);
-	}
+// 	}
 
 	if (unlikely(status & PORT_IRQ_ERROR)) {
 		ahci_error_intr(ap, status);


I haven't read the specification, so this might be bad. I did this in
base of some consideration I made that, as far as I know, could be
completely wrong. I hope you can get something meaningful out of this.

Gabriele

  parent reply	other threads:[~2015-01-12 23:05 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-08 19:37 SATA link power management issues Gabriele Mazzotta
2015-01-09 22:00 ` Tejun Heo
2015-01-09 22:02   ` Tejun Heo
2015-01-09 22:05     ` Tejun Heo
2015-01-09 22:50     ` Gabriele Mazzotta
2015-01-12 13:16       ` Tejun Heo
2015-01-12 17:03         ` Gabriele Mazzotta
2015-01-12 17:07           ` Tejun Heo
2015-01-12 17:15             ` Gabriele Mazzotta
2015-01-09 22:40   ` Gabriele Mazzotta
     [not found] ` <CAOHikRDTgVWL7_WUS3Yvce01GyP5TcyRm8ojfAyTHLTZ7xiR7A@mail.gmail.com>
2015-01-12 17:16   ` Suman Tripathi
2015-01-12 20:26     ` Gabriele Mazzotta
     [not found]       ` <CAOHikRCp=m6tgKEmdg2pLj=XB2ugCGhj0rkeqCzF2+DPR8O9sw@mail.gmail.com>
2015-01-12 20:36         ` Gabriele Mazzotta
     [not found]           ` <CAOHikRC43JBMwCahBqT1znJLBnbr3Ui+szKhVQoK8cpfapTQyg@mail.gmail.com>
2015-01-12 20:54             ` Gabriele Mazzotta
2015-01-12 23:05 ` Gabriele Mazzotta [this message]
2015-02-22 20:53   ` Gabriele Mazzotta
2015-04-20 20:02     ` Gabriele Mazzotta
2015-04-21 15:31       ` Tejun Heo
2015-04-21 20:29         ` Gabriele Mazzotta
2015-04-21 20:56           ` Tejun Heo
2015-04-21 21:44             ` Gabriele Mazzotta
2015-04-24 21:44               ` Tejun Heo
2015-04-25  9:34                 ` [PATCH] libata: Ignore spurious PHY events on LPM policy change Gabriele Mazzotta
2015-04-25 15:37                   ` Tejun Heo
2015-04-25 17:57                     ` Gabriele Mazzotta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2526428.uJaEqCTeIa@xps13 \
    --to=gabriele.mzt@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stripathi@apm.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).