From: Damien Le Moal <dlemoal@kernel.org>
To: Sergey Shtylyov <s.shtylyov@omp.ru>, linux-ide@vger.kernel.org
Cc: linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
John Garry <john.g.garry@oracle.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Paul Ausbeck <paula@soe.ucsc.edu>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Joe Breuer <linux-kernel@jmbreuer.net>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Chia-Lin Kao <acelan.kao@canonical.com>
Subject: Re: [PATCH v4 19/23] ata: libata-core: Do not resume runtime suspended ports
Date: Thu, 21 Sep 2023 10:31:10 -0700 [thread overview]
Message-ID: <274c4526-49b0-b8a3-81ca-67889a403901@kernel.org> (raw)
In-Reply-To: <cb714cbb-0fba-6774-f525-726b829af02e@omp.ru>
On 2023/09/21 0:32, Sergey Shtylyov wrote:
> On 9/20/23 4:54 PM, Damien Le Moal wrote:
>
>> The scsi disk driver does not resume disks that have been runtime
>> suspended by the user. To be consistent with this behavior, do the same
>> for ata ports and skip the PM request in ata_port_pm_resume() if the
>> port was already runtime suspended. With this change, it is no longer
>> necessary to for the PM state of the port to ACTIVE as the PM core code
> ^^^^^^
> Can't parse this. :-)
s/for/force
Will fix that.
>
>> will take care of that when handling runtime resume.
>>
>> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
>> Reviewed-by: Hannes Reinecke <hare@suse.de>
>> Tested-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com>
> [...]
>
> MBR, Sergey
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2023-09-21 19:05 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 13:54 [PATCH v4 00/23] Fix libata suspend/resume handling and code cleanup Damien Le Moal
2023-09-20 13:54 ` [PATCH v4 01/23] ata: libata-core: Fix ata_port_request_pm() locking Damien Le Moal
2023-09-20 18:54 ` Niklas Cassel
2023-09-20 13:54 ` [PATCH v4 02/23] ata: libata-core: Fix port and device removal Damien Le Moal
2023-09-20 13:54 ` [PATCH v4 03/23] ata: libata-scsi: link ata port and scsi device Damien Le Moal
2023-09-20 18:55 ` Niklas Cassel
2023-09-21 14:16 ` John Garry
2023-09-21 17:30 ` Damien Le Moal
2023-09-20 13:54 ` [PATCH v4 04/23] scsi: sd: Differentiate system and runtime start/stop management Damien Le Moal
2023-09-21 21:45 ` Bart Van Assche
2023-09-22 17:00 ` Damien Le Moal
2023-09-20 13:54 ` [PATCH v4 05/23] ata: libata-scsi: Disable scsi device manage_system_start_stop Damien Le Moal
2023-09-20 13:54 ` [PATCH v4 06/23] scsi: Do not attempt to rescan suspended devices Damien Le Moal
2023-09-20 13:54 ` [PATCH v4 07/23] ata: libata-scsi: Fix delayed scsi_rescan_device() execution Damien Le Moal
2023-09-20 13:54 ` [PATCH v4 08/23] ata: libata-core: Do not register PM operations for SAS ports Damien Le Moal
2023-09-21 14:01 ` John Garry
2023-09-20 13:54 ` [PATCH v4 09/23] scsi: sd: Do not issue commands to suspended disks on shutdown Damien Le Moal
2023-09-21 21:36 ` Bart Van Assche
2023-09-21 22:06 ` Damien Le Moal
2023-09-20 13:54 ` [PATCH v4 10/23] ata: libata-core: Fix compilation warning in ata_dev_config_ncq() Damien Le Moal
2023-09-20 13:54 ` [PATCH v4 11/23] ata: libata-eh: Fix compilation warning in ata_eh_link_report() Damien Le Moal
2023-09-20 13:54 ` [PATCH v4 12/23] scsi: Remove scsi device no_start_on_resume flag Damien Le Moal
2023-09-20 13:54 ` [PATCH v4 13/23] ata: libata-scsi: Cleanup ata_scsi_start_stop_xlat() Damien Le Moal
2023-09-20 13:54 ` [PATCH v4 14/23] ata: libata-core: Synchronize ata_port_detach() with hotplug Damien Le Moal
2023-09-20 13:54 ` [PATCH v4 15/23] ata: libata-core: Detach a port devices on shutdown Damien Le Moal
2023-09-20 13:54 ` [PATCH v4 16/23] ata: libata-core: Remove ata_port_suspend_async() Damien Le Moal
2023-09-20 13:54 ` [PATCH v4 17/23] ata: libata-core: Remove ata_port_resume_async() Damien Le Moal
2023-09-20 13:54 ` [PATCH v4 18/23] ata: libata-core: Do not poweroff runtime suspended ports Damien Le Moal
2023-09-20 13:54 ` [PATCH v4 19/23] ata: libata-core: Do not resume " Damien Le Moal
2023-09-21 7:32 ` Sergey Shtylyov
2023-09-21 17:31 ` Damien Le Moal [this message]
2023-09-20 13:54 ` [PATCH v4 20/23] ata: libata-sata: Improve ata_sas_slave_configure() Damien Le Moal
2023-09-20 13:54 ` [PATCH v4 21/23] ata: libata-eh: Improve reset error messages Damien Le Moal
2023-09-20 13:54 ` [PATCH v4 22/23] ata: libata-eh: Reduce "disable device" message verbosity Damien Le Moal
2023-09-20 13:54 ` [PATCH v4 23/23] ata: libata: Cleanup inline DMA helper functions Damien Le Moal
2023-09-21 9:21 ` [PATCH v4 00/23] Fix libata suspend/resume handling and code cleanup Geert Uytterhoeven
2023-09-21 9:22 ` Geert Uytterhoeven
2023-09-21 17:30 ` Damien Le Moal
2023-09-21 19:53 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=274c4526-49b0-b8a3-81ca-67889a403901@kernel.org \
--to=dlemoal@kernel.org \
--cc=acelan.kao@canonical.com \
--cc=geert@linux-m68k.org \
--cc=john.g.garry@oracle.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@jmbreuer.net \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=paula@soe.ucsc.edu \
--cc=rodrigo.vivi@intel.com \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox