linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ray Lee <madrabbit@gmail.com>
To: Brett Russ <russb@emc.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 2.6.13] libata: Marvell SATA support (PIO mode)
Date: Fri, 2 Sep 2005 10:55:00 -0700	[thread overview]
Message-ID: <2c0942db05090210556ad0a7d@mail.gmail.com> (raw)
In-Reply-To: <20050901222617.2455520F96@lns1058.lss.emc.com>

On 9/1/05, Brett Russ <russb@emc.com> wrote:
> More (non-functional) style modifications since the version 0.11
> driver I sent out earlier today.  Removed most parens around return
> value, 

return is not a function call; you can safely remove them all.

> +       return ((void __iomem *)((unsigned long)port_mmio &
> +                                (unsigned long)SATAHC_MASK));
> +       return (base + MV_SATAHC0_REG_BASE + (hc * MV_SATAHC_REG_SZ));
> +       return (mv_hc_base(base, port >> MV_PORT_HC_SHIFT) +
> +               MV_SATAHC_ARBTR_REG_SZ +
> +               ((port & MV_PORT_MASK) * MV_PORT_REG_SZ));
> +       return ((flags & MV_FLAG_DUAL_HC) ? 2 : 1);
> +       return (EDMA_EN & readl(port_mmio + EDMA_CMD_OFS));
> +       return (ap->flags & MV_FLAG_BDMA);

Ray

  parent reply	other threads:[~2005-09-02 17:55 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-30 18:36 [RFC][PATCH 2.6.13] Marvell SATA support (PIO mode) Brett Russ
2005-08-30 20:48 ` Jeff Garzik
2005-09-01 14:27   ` [PATCH 2.6.13] libata: " Brett Russ
2005-09-01 14:40     ` Christoph Hellwig
2005-09-01 19:48       ` Jeff Garzik
2005-09-01 19:58         ` Christoph Hellwig
2005-09-01 20:03           ` Jeff Garzik
2005-09-01 20:04             ` Jeff Garzik
2005-09-01 20:05             ` Christoph Hellwig
2005-09-01 20:28               ` Jeff Garzik
2005-09-01 22:26       ` Brett Russ
2005-09-02  1:32         ` Brett Russ
2005-09-02 17:16         ` Bogdan Costescu
2005-09-02 17:55         ` Ray Lee [this message]
2005-09-07  5:56         ` Jeff Garzik
2005-09-07 14:40           ` Brett Russ
2005-09-07 16:31             ` Bogdan Costescu
2005-09-03 14:08     ` Tyler
2005-09-03 17:29       ` Jeff Garzik
2005-09-27  5:36       ` Tyler
2005-08-31 10:35 ` [RFC][PATCH 2.6.13] " Jiri Slaby
2005-08-31 11:37   ` Brett Russ
  -- strict thread matches above, loose matches on Subject: below --
2005-09-01 20:19 [PATCH 2.6.13] libata: " linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c0942db05090210556ad0a7d@mail.gmail.com \
    --to=madrabbit@gmail.com \
    --cc=hch@infradead.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ray@madrabbit.org \
    --cc=russb@emc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).