From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ray Lee Subject: Re: [PATCH 2.6.13] libata: Marvell SATA support (PIO mode) Date: Fri, 2 Sep 2005 10:55:00 -0700 Message-ID: <2c0942db05090210556ad0a7d@mail.gmail.com> References: <20050830183625.BEE1520F4C@lns1058.lss.emc.com> <4314C604.4030208@pobox.com> <20050901142754.B93BF27137@lns1058.lss.emc.com> <20050901144038.GA25830@infradead.org> <20050901222617.2455520F96@lns1058.lss.emc.com> Reply-To: ray@madrabbit.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from xproxy.gmail.com ([66.249.82.193]:19236 "EHLO xproxy.gmail.com") by vger.kernel.org with ESMTP id S1750755AbVIBRzC convert rfc822-to-8bit (ORCPT ); Fri, 2 Sep 2005 13:55:02 -0400 Received: by xproxy.gmail.com with SMTP id i31so398017wxd for ; Fri, 02 Sep 2005 10:55:00 -0700 (PDT) In-Reply-To: <20050901222617.2455520F96@lns1058.lss.emc.com> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Brett Russ Cc: Jeff Garzik , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig On 9/1/05, Brett Russ wrote: > More (non-functional) style modifications since the version 0.11 > driver I sent out earlier today. Removed most parens around return > value, return is not a function call; you can safely remove them all. > + return ((void __iomem *)((unsigned long)port_mmio & > + (unsigned long)SATAHC_MASK)); > + return (base + MV_SATAHC0_REG_BASE + (hc * MV_SATAHC_REG_SZ)); > + return (mv_hc_base(base, port >> MV_PORT_HC_SHIFT) + > + MV_SATAHC_ARBTR_REG_SZ + > + ((port & MV_PORT_MASK) * MV_PORT_REG_SZ)); > + return ((flags & MV_FLAG_DUAL_HC) ? 2 : 1); > + return (EDMA_EN & readl(port_mmio + EDMA_CMD_OFS)); > + return (ap->flags & MV_FLAG_BDMA); Ray