From: Hannes Reinecke <hare@suse.de>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
linux-ide@vger.kernel.org,
"Maciej S . Szmigiero" <mail@maciej.szmigiero.name>
Subject: Re: [PATCH 3/3] ata: libata: Enable fua support by default
Date: Fri, 21 Oct 2022 08:22:05 +0200 [thread overview]
Message-ID: <2d1f1e3b-8e91-271a-3da3-fd640cdf3188@suse.de> (raw)
In-Reply-To: <20221021053809.237651-4-damien.lemoal@opensource.wdc.com>
On 10/21/22 07:38, Damien Le Moal wrote:
> Change the default value of the fua module parameter to 1 to enable fua
> support by default for all devices supporting it. This parameter
> description is also updated to indicate it is deprecated and that
> libata.force=[no]fua should be used to control fua support.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/libata-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 1bb9616b10d9..140e7e7d7833 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -127,9 +127,9 @@ int atapi_passthru16 = 1;
> module_param(atapi_passthru16, int, 0444);
> MODULE_PARM_DESC(atapi_passthru16, "Enable ATA_16 passthru for ATAPI devices (0=off, 1=on [default])");
>
> -int libata_fua = 0;
> +int libata_fua = 1;
> module_param_named(fua, libata_fua, int, 0644);
> -MODULE_PARM_DESC(fua, "FUA support (0=off [default], 1=on)");
> +MODULE_PARM_DESC(fua, "FUA support (0=off, 1=on [default])");
>
> static int ata_ignore_hpa;
> module_param_named(ignore_hpa, ata_ignore_hpa, int, 0644);
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman
next prev parent reply other threads:[~2022-10-21 6:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 5:38 [PATCH 0/3] Improve libata support for FUA Damien Le Moal
2022-10-21 5:38 ` [PATCH 1/3] ata: libata: cleanup fua handling Damien Le Moal
2022-10-21 6:20 ` Hannes Reinecke
2022-10-21 5:38 ` [PATCH 2/3] ata: libata: allow toggling fua parameter at runtime Damien Le Moal
2022-10-21 6:21 ` Hannes Reinecke
2022-10-21 6:50 ` Damien Le Moal
2022-10-21 8:00 ` Damien Le Moal
2022-10-21 8:45 ` Hannes Reinecke
2022-10-21 8:48 ` Damien Le Moal
2022-10-21 5:38 ` [PATCH 3/3] ata: libata: Enable fua support by default Damien Le Moal
2022-10-21 6:22 ` Hannes Reinecke [this message]
2022-10-21 21:02 ` [PATCH 0/3] Improve libata support for FUA Maciej S. Szmigiero
2022-10-21 22:45 ` Damien Le Moal
2022-10-22 13:50 ` Hannes Reinecke
2022-10-23 0:27 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d1f1e3b-8e91-271a-3da3-fd640cdf3188@suse.de \
--to=hare@suse.de \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-ide@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox