From: Damien Le Moal <dlemoal@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Niklas Cassel <cassel@kernel.org>
Subject: Re: [PATCH v1 1/1] pata_rdc: Use registered definition for the RDC vendor
Date: Mon, 14 Jul 2025 16:14:14 +0900 [thread overview]
Message-ID: <2e63f7ec-f9ed-4ad3-b27b-a5d6e120bff6@kernel.org> (raw)
In-Reply-To: <aHSt65bhITAzN_2x@smile.fi.intel.com>
On 7/14/25 4:12 PM, Andy Shevchenko wrote:
> On Mon, Jul 14, 2025 at 09:32:09AM +0900, Damien Le Moal wrote:
>> On 7/11/25 8:36 PM, Andy Shevchenko wrote:
>>> Convert to PCI_VDEVICE() and use registered definition for RDC vendor
>>> from pci_ids.h.
>>>
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>
>> Commit title needs "ata: " prefix. Niklas, can you add it when applying ?
>
> I took the output of
>
> $ git log --oneline --no-merges -- drivers/ata/pata_rdc.c
>
> and tried to deduct what will be the driver specific prefix, there are no
> ata: pata_rdc: prefixed changes, so it appears that I made wrong assumption.
It is probably because that driver has not been touched in a long time :)
These days, we try to be consistent with the patch titles and have the "ata: "
prefix for all of them to make git log searches easier.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-07-14 7:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 11:36 [PATCH v1 1/1] pata_rdc: Use registered definition for the RDC vendor Andy Shevchenko
2025-07-14 0:32 ` Damien Le Moal
2025-07-14 7:12 ` Andy Shevchenko
2025-07-14 7:14 ` Damien Le Moal [this message]
2025-07-14 7:28 ` Niklas Cassel
2025-07-14 7:25 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e63f7ec-f9ed-4ad3-b27b-a5d6e120bff6@kernel.org \
--to=dlemoal@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cassel@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox