From: Hannes Reinecke <hare@suse.de>
To: Damien Le Moal <dlemoal@kernel.org>,
linux-ide@vger.kernel.org, Niklas Cassel <cassel@kernel.org>
Cc: Igor Pylypiv <ipylypiv@google.com>, Xingui Yang <yangxingui@huawei.com>
Subject: Re: [PATCH 1/2] ata: libata-scsi: refactor ata_scsi_translate()
Date: Thu, 18 Dec 2025 10:23:17 +0100 [thread overview]
Message-ID: <309c96aa-e6ae-4bd3-8488-0e193a731bec@suse.de> (raw)
In-Reply-To: <20251217231712.490765-2-dlemoal@kernel.org>
On 12/18/25 00:17, Damien Le Moal wrote:
> Factor out of ata_scsi_translate() the code handling queued command
> deferral using the port qc_defer callback into the new function
> ata_scsi_defer(), and simplify the goto used in ata_scsi_translate().
> While at it, also add a lockdep annotation to check that the port lock
> is held when ata_scsi_translate() is called.
>
> No functional changes.
>
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> ---
> drivers/ata/libata-scsi.c | 66 ++++++++++++++++++++++++---------------
> 1 file changed, 40 insertions(+), 26 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
next prev parent reply other threads:[~2025-12-18 9:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 23:17 [PATCH 0/2] Prevent non-NCQ command starvation Damien Le Moal
2025-12-17 23:17 ` [PATCH 1/2] ata: libata-scsi: refactor ata_scsi_translate() Damien Le Moal
2025-12-18 9:23 ` Hannes Reinecke [this message]
2025-12-17 23:17 ` [PATCH 2/2] ata: libata-scsi: avoid passthrough command starvation Damien Le Moal
2025-12-18 9:26 ` Hannes Reinecke
2025-12-19 0:08 ` Igor Pylypiv
2025-12-19 7:47 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=309c96aa-e6ae-4bd3-8488-0e193a731bec@suse.de \
--to=hare@suse.de \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=ipylypiv@google.com \
--cc=linux-ide@vger.kernel.org \
--cc=yangxingui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox