Re: [PATCH v2 1/5] ata: libata: rename ata_dev_is_zac()

[Hannes Reinecke <hare@suse.de>]

On 7/2/26 8:34 AM, Damien Le Moal wrote:
> The helper function ata_dev_is_zac() checks if a device is a ZAC class
> device (host managed zoned disk) or if it is a host aware zoned disk, that
> is, a regular ATA disk that supports the zoned capabilities. So the name
> of this helper function is confusing as it hints at the first case only.
> 
> Rename this helper function to ata_dev_is_zoned() to avoid confusions and
> better reflect the two cases tested.
> 
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> ---
>   drivers/ata/libata-core.c | 6 +++---
>   drivers/ata/libata-scsi.c | 7 +++----
>   drivers/ata/libata.h      | 2 +-
>   3 files changed, 7 insertions(+), 8 deletions(-)
> 
Sigh ... This was the first function I ever coded when starting SMR support.

You could have shown a bit more respect ;-)

Reviewed-by: Hannes Reinecke <hare@kernel.org>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich