From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] ata:Remove no longer valid FIXME comment in pata_ninja32.c for the function,ninja32_init_one Date: Thu, 05 Feb 2015 12:02:06 +0100 Message-ID: <3201438.osoPqSWP4R@amdc1032> References: <1423093661-32188-1-git-send-email-xerofoify@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7Bit Return-path: Received: from mailout4.samsung.com ([203.254.224.34]:41638 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751212AbbBELCT (ORCPT ); Thu, 5 Feb 2015 06:02:19 -0500 In-reply-to: <1423093661-32188-1-git-send-email-xerofoify@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Nicholas Krause Cc: tj@kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, One Thousand Gnomes Hi, On Wednesday, February 04, 2015 06:47:41 PM Nicholas Krause wrote: > Removes the no longer valid fix me comment in the function, ninja32_init_one for > questioning if we are required to remove the activated device at the end of this > function by calling the function, ata_host_activate to activate the device passed > by the caller of the function ninja_init_one. This comment is no longer needed as > we need to deallocate the memory used to store this device's information when the > device is no longer in use by the system in order to avoid leaking memory. Due to > this the driver in the file,ninja32_init_one has the function,ata_pci_remove_one > to release the memory allocated in it's init function and therefore this comment > can now be removed due to use correctly freeing the memory allocated from the > driver's init function,ninja32_init_one. > > Signed-off-by: Nicholas Krause > --- > drivers/ata/pata_ninja32.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/ata/pata_ninja32.c b/drivers/ata/pata_ninja32.c > index efb272d..47b30d3 100644 > --- a/drivers/ata/pata_ninja32.c > +++ b/drivers/ata/pata_ninja32.c > @@ -147,7 +147,6 @@ static int ninja32_init_one(struct pci_dev *dev, const struct pci_device_id *id) > ap->pflags = ATA_PFLAG_PIO32 | ATA_PFLAG_PIO32CHANGE; > > ninja32_program(base); > - /* FIXME: Should we disable them at remove ? */ After looking at the driver history I think that the comment is about ninja32_program() enabling interrupt lines (which don't get disabled when the host controller is detached from the driver) not about the cleanup done during ata_pci_remove_one(). Alan, is this correct? > return ata_host_activate(host, dev->irq, ata_bmdma_interrupt, > IRQF_SHARED, &ninja32_sht); > } Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics