From: Dmitry Osipenko <digetx@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>,
axboe@kernel.dk, thierry.reding@gmail.com
Cc: jonathanh@nvidia.com, linux-ide@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present
Date: Thu, 8 Apr 2021 22:58:06 +0300 [thread overview]
Message-ID: <32ff84ba-60a7-e498-d656-bcd29d23fb02@gmail.com> (raw)
In-Reply-To: <1617900043-10506-2-git-send-email-skomatineni@nvidia.com>
08.04.2021 19:40, Sowjanya Komatineni пишет:
> This patch adds a check on present of PM domain and calls legacy power
> domain API tegra_powergate_power_off() only when PM domain is not present.
>
> This is a follow-up patch to Tegra186 AHCI support patch series
> https://lore.kernel.org/patchwork/cover/1408752/
>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>
> ---
> drivers/ata/ahci_tegra.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
> index 56612af..bd484dd 100644
> --- a/drivers/ata/ahci_tegra.c
> +++ b/drivers/ata/ahci_tegra.c
> @@ -287,7 +287,8 @@ static void tegra_ahci_power_off(struct ahci_host_priv *hpriv)
> reset_control_assert(tegra->sata_cold_rst);
>
> clk_disable_unprepare(tegra->sata_clk);
> - tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
> + if (!tegra->pdev->dev.pm_domain)
> + tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
>
> regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies);
> }
>
There are two instances of tegra_powergate_power_off() in the driver.
next prev parent reply other threads:[~2021-04-08 19:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 16:40 [PATCH v1] Follow up patch to Tegra186 AHCI support patch series Sowjanya Komatineni
2021-04-08 16:40 ` [PATCH v1] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present Sowjanya Komatineni
2021-04-08 19:58 ` Dmitry Osipenko [this message]
2021-04-08 20:49 ` Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32ff84ba-60a7-e498-d656-bcd29d23fb02@gmail.com \
--to=digetx@gmail.com \
--cc=axboe@kernel.dk \
--cc=jonathanh@nvidia.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox