From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] ata: dwc: add DMADEVICES dependency Date: Wed, 11 May 2016 15:32:18 +0200 Message-ID: <3357570.y2pHcSUkFV@wuerfel> References: <1462970683-451525-1-git-send-email-arnd@arndb.de> <4546329.1O9421M58I@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mout.kundenserver.de ([212.227.126.135]:55336 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932593AbcEKNcc convert rfc822-to-8bit (ORCPT ); Wed, 11 May 2016 09:32:32 -0400 In-Reply-To: Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: =?ISO-8859-1?Q?M=E5ns_Rullg=E5rd?= Cc: Tejun Heo , Andy Shevchenko , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org On Wednesday 11 May 2016 14:19:05 M=E5ns Rullg=E5rd wrote: > Arnd Bergmann writes: >=20 > > On Wednesday 11 May 2016 13:57:08 M=E5ns Rullg=E5rd wrote: > >> > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig > >> > index 41b0725e58ad..8f7a4a4d2566 100644 > >> > --- a/drivers/ata/Kconfig > >> > +++ b/drivers/ata/Kconfig > >> > @@ -322,7 +322,7 @@ config SATA_DWC > >> > > >> > config SATA_DWC_OLD_DMA > >> > bool "Support old device trees" > >> > - depends on SATA_DWC > >> > + depends on SATA_DWC && DMADEVICES > >> > select DW_DMAC_CORE > >> > default y if 460EX > >> > help > >> > --=20 > >>=20 > >> Isn't the proper fix here to have DW_DMAC_CORE select DMADEVICES? > > > > No, all dmaengine drivers depend on DMADEVICES, so that would > > cause a circular dependency. > > > > The normal behavior for DMA slave drivers is to use the generic > > DMA API and have a dependency on DMADEVICES but not on a particular > > DMA engine implementation. In this case, the driver uses an exporte= d > > interface of the dw_dma driver directly, so we also need to select > > that one, but it doesn't mean we can skip the normal dependency. >=20 > OK, but then shouldn't the main SATA_DWC have this dependency since i= t > uses the DMA API? >=20 Right, I missed that and thought only the SATA_DWC_OLD_DMA variant used dmaengine at all. I'll send a new version of my patch then. Thanks, Arnd