From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: menglong8.dong@gmail.com, axboe@kernel.dk
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Menglong Dong <dong.menglong@zte.com.cn>
Subject: Re: [PATCH] ata: remove redundant error print in rb532_pata_driver_probe
Date: Tue, 12 Jan 2021 14:15:25 +0300 [thread overview]
Message-ID: <33bb1cd2-c202-0fd5-733d-b44e7e8fa92c@gmail.com> (raw)
In-Reply-To: <20210112023619.5713-1-dong.menglong@zte.com.cn>
Hello!
On 1/12/21 5:36 AM, menglong8.dong@gmail.com wrote:
> From: Menglong Dong <dong.menglong@zte.com.cn>
>
> Coccinelle reports a redundant error print in rb532_pata_driver_probe.
> As 'platform_get_irq' already prints the error message, error print
> here is redundant and can be removed.
>
> Signed-off-by: Menglong Dong <dong.menglong@zte.com.cn>
> ---
> drivers/ata/pata_rb532_cf.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/ata/pata_rb532_cf.c b/drivers/ata/pata_rb532_cf.c
> index 479c4b29b856..dcde84f571c4 100644
> --- a/drivers/ata/pata_rb532_cf.c
> +++ b/drivers/ata/pata_rb532_cf.c
> @@ -115,10 +115,8 @@ static int rb532_pata_driver_probe(struct platform_device *pdev)
> }
>
> irq = platform_get_irq(pdev, 0);
> - if (irq <= 0) {
> - dev_err(&pdev->dev, "no IRQ resource found\n");
> + if (irq <= 0)
> return -ENOENT;
This still beaks the probe deferral. :-(
But that's another problem...
[...]
MBR, Sergei
next prev parent reply other threads:[~2021-01-12 11:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 2:36 [PATCH] ata: remove redundant error print in rb532_pata_driver_probe menglong8.dong
2021-01-12 11:15 ` Sergei Shtylyov [this message]
2021-01-13 14:04 ` Menglong Dong
2021-01-14 8:29 ` Sergei Shtylyov
2021-01-14 14:53 ` Menglong Dong
2021-01-14 15:49 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33bb1cd2-c202-0fd5-733d-b44e7e8fa92c@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=axboe@kernel.dk \
--cc=dong.menglong@zte.com.cn \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menglong8.dong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).