From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Tejun Heo <tj@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [GIT PULL] libata fixes for v3.13-rc5
Date: Wed, 25 Dec 2013 15:45:08 +0100 [thread overview]
Message-ID: <38559427.MeFx9E3dcV@vostro.rjw.lan> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1312241653360.337-100000@netrider.rowland.org>
On Tuesday, December 24, 2013 04:55:46 PM Alan Stern wrote:
> On Tue, 24 Dec 2013, Tejun Heo wrote:
>
> > Hello, Linus.
> >
> > libata fixes for v3.13-rc5. There's one interseting commit - "libata,
> > freezer: avoid block device removal while system is frozen". It's an
> > ugly hack working around a deadlock condition between driver core
> > resume and block layer device removal paths through freezer which was
> > made more reproducible by writeback being converted to workqueue some
> > releases ago. The bug has nothing to do with libata but it's just an
> > workaround which is easy to backport. After discussion, Rafael and I
> > seem to agree that we don't really need kernel freezables - both
> > kthread and workqueue. There are few specific workqueues which
> > constitute PM operations and require freezing, which will be converted
> > to use workqueue_set_max_active() instead. All other kernel freezer
> > uses are planned to be removed, followed by the removal of kthread and
> > workqueue freezer support, hopefully.
>
> Wait a minute. I don't recall anybody mentioning this earlier. What
> about khubd? There isn't any plan to remove _it_.
No, but we are going to replace the freezing of kernel stuff with something
more direct, like "suspend" routines called from the system suspend code path
and causing things to stop (and corresponding "resume" starting them again).
Thanks,
Rafael
next prev parent reply other threads:[~2013-12-25 14:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 14:21 [GIT PULL] libata fixes for v3.13-rc5 Tejun Heo
2013-12-24 21:55 ` Alan Stern
2013-12-25 14:45 ` Rafael J. Wysocki [this message]
2013-12-25 14:57 ` Alan Stern
2013-12-25 22:12 ` Rafael J. Wysocki
2013-12-26 3:29 ` No freezing of kernel threads (was: Re: [GIT PULL] libata fixes for v3.13-rc5) Alan Stern
2013-12-26 4:18 ` Tejun Heo
2013-12-26 15:05 ` Rafael J. Wysocki
2013-12-26 16:05 ` Tejun Heo
2013-12-26 18:42 ` Alan Stern
2013-12-26 19:01 ` Tejun Heo
2013-12-26 23:23 ` Rafael J. Wysocki
2013-12-27 2:14 ` Alan Stern
2013-12-27 2:21 ` Tejun Heo
2013-12-26 23:49 ` Rafael J. Wysocki
2014-01-11 21:15 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38559427.MeFx9E3dcV@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox