Re: [PATCH v2] ata: sata_mv: Fix the error handling of mv_chip_id()

[Damien Le Moal <damien.lemoal@opensource.wdc.com>]

On 2021/10/22 18:12, Zheyu Ma wrote:
> mv_init_host() propagates the value returned by mv_chip_id() which in turn
> gets propagated by mv_pci_init_one() and hits local_pci_probe().
> 
> During the process of driver probing, the probe function should return < 0
> for failure, otherwise, the kernel will treat value > 0 as success.
> 
> Since this is a bug rather than a recoverable runtime error we should
> use dev_alert() instead of dev_err().
> 
> Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
> ---
> Changes in v2:
>     - Change the error code
>     - Change the logging function
> ---
>  drivers/ata/sata_mv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
> index 9d86203e1e7a..c53633d47bfb 100644
> --- a/drivers/ata/sata_mv.c
> +++ b/drivers/ata/sata_mv.c
> @@ -3896,8 +3896,8 @@ static int mv_chip_id(struct ata_host *host, unsigned int board_idx)
>  		break;
>  
>  	default:
> -		dev_err(host->dev, "BUG: invalid board index %u\n", board_idx);
> -		return 1;
> +		dev_alert(host->dev, "BUG: invalid board index %u\n", board_idx);
> +		return -EINVAL;
>  	}
>  
>  	hpriv->hp_flags = hp_flags;
> 

Applied to for-5.15-fixes. Thanks !

-- 
Damien Le Moal
Western Digital Research