From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0
Date: Thu, 6 Oct 2022 11:37:17 +0300 [thread overview]
Message-ID: <3a89c963-df7c-8fac-7213-d37c1b04f864@omp.ru> (raw)
In-Reply-To: <a8c87c6d8dd6d9e57c515036a333ff89fc56bcbf.1665033366.git.christophe.leroy@csgroup.eu>
Hello!
Perhaps s/by/with/ in the subject?
On 10/6/22 8:17 AM, Christophe Leroy wrote:
> NO_IRQ is used to check the return of irq_of_parse_and_map().
>
> On some architecture NO_IRQ is 0, on other architectures it is -1.
>
> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
>
> So use 0 instead of using NO_IRQ.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
next prev parent reply other threads:[~2022-10-06 8:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 5:17 [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0 Christophe Leroy
2022-10-06 5:45 ` Damien Le Moal
2022-10-06 5:49 ` Christophe Leroy
2022-10-06 6:30 ` Damien Le Moal
2022-10-06 8:19 ` Christophe Leroy
2022-10-06 8:37 ` Sergey Shtylyov [this message]
2022-10-06 8:43 ` Damien Le Moal
2022-10-17 2:43 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a89c963-df7c-8fac-7213-d37c1b04f864@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=christophe.leroy@csgroup.eu \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox