Re: [PATCH] ata: libata-scsi: refactor ata_scsiop_maint_in()

[Damien Le Moal <dlemoal@kernel.org>]

On 3/20/26 19:59, Niklas Cassel wrote:
> ata_scsiop_maint_in() is currently quite confusing to read, because it
> currently only implements support for the service action REPORT SUPPORTED
> OPERATION CODES.
> 
> Thus, when this function is checking for "invalid command format", it is
> not very clear if it is an invalid command format for the MAINTENANCE IN
> command itself, or an invalid command format for the (currently one and
> only) service action/subcommand implemented for this command.
> 
> Move the service action to a separate function, so it is more clear that
> the "invalid command format" check is actually specific for the REPORT
> SUPPORTED OPERATION CODES service action.
> 
> This also makes it easier and less confusing to add support for additional
> service actions in the future.
> 
> Signed-off-by: Niklas Cassel <cassel@kernel.org>

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>


-- 
Damien Le Moal
Western Digital Research