From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 218FDC28B2B for ; Fri, 19 Aug 2022 07:54:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347131AbiHSHyt (ORCPT ); Fri, 19 Aug 2022 03:54:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345865AbiHSHyr (ORCPT ); Fri, 19 Aug 2022 03:54:47 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B5F0DB04A; Fri, 19 Aug 2022 00:54:45 -0700 (PDT) Received: from fraeml712-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4M8DTw5Pw8z68BVL; Fri, 19 Aug 2022 15:51:32 +0800 (CST) Received: from lhrpeml500003.china.huawei.com (7.191.162.67) by fraeml712-chm.china.huawei.com (10.206.15.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 19 Aug 2022 09:54:42 +0200 Received: from [10.195.34.98] (10.195.34.98) by lhrpeml500003.china.huawei.com (7.191.162.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 19 Aug 2022 08:54:42 +0100 Message-ID: <4014a51d-0925-c0dc-70dc-1a465dd278e7@huawei.com> Date: Fri, 19 Aug 2022 08:54:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression To: Oliver Sang , Damien Le Moal CC: Christoph Hellwig , "Martin K. Petersen" , LKML , "Linux Memory Management List" , , , , , , , References: <2e9cf5a6-c043-5ccf-e363-097c6c941891@huawei.com> <43eaa104-5b09-072c-56aa-6289569b0015@opensource.wdc.com> <28d6e48b-f52f-9467-8260-262504a1a1ff@huawei.com> <743867a6-b266-58e4-a8a6-542757916f0a@huawei.com> From: John Garry In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.195.34.98] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500003.china.huawei.com (7.191.162.67) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 19/08/2022 07:24, Oliver Sang wrote: >> As you probably saw, I sent "[RFT PATCH] ata: libata: Set __ATA_BASE_SHT >> max_sectors" for testing on top of v6.0-rc1, and I hope that then we can get Based on result below, I wonder if SAS HBAs (which use libata) should not use default SCSI max_sectors also. Any libsas HBA driver does today, IIRC. >> same performance as v5.19 > yeah, our test confirmed your expectation: > > stress-ng.copy-file.ops_per_sec > v5.19 - 26.85 > v6.0-rc1 - 23.03 > v6.0-rc1 + your patch - 26.94 > great, thanks Thanks, John