[PATCH] fix Silicon Image SATA 4-port support

[PATCH] fix Silicon Image SATA 4-port support

[Jeff Garzik]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]


Do not be fooled, Silicon Image is still marked CONFIG_BROKEN for a 
reason...  :)  But this should (hopefully!) get 4-port support going.

Testing requested...



[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 2166 bytes --]

===== drivers/scsi/sata_sil.c 1.7 vs edited =====
--- 1.7/drivers/scsi/sata_sil.c	Wed Jan 14 18:34:44 2004
+++ edited/drivers/scsi/sata_sil.c	Wed Feb 25 02:24:24 2004
@@ -44,6 +44,11 @@
 	SIL_SYSCFG		= 0x48,
 	SIL_MASK_IDE0_INT	= (1 << 22),
 	SIL_MASK_IDE1_INT	= (1 << 23),
+	SIL_MASK_IDE2_INT	= (1 << 24),
+	SIL_MASK_IDE3_INT	= (1 << 25),
+	SIL_MASK_2PORT		= SIL_MASK_IDE0_INT | SIL_MASK_IDE1_INT,
+	SIL_MASK_4PORT		= SIL_MASK_2PORT |
+				  SIL_MASK_IDE2_INT | SIL_MASK_IDE3_INT,
 
 	SIL_IDE0_TF		= 0x80,
 	SIL_IDE0_CTL		= 0x8A,
@@ -59,6 +64,7 @@
 	SIL_IDE2_CTL		= 0x28A,
 	SIL_IDE2_BMDMA		= 0x200,
 	SIL_IDE2_SCR		= 0x300,
+	SIL_INTR_STEERING	= (1 << 1),
 
 	SIL_IDE3_TF		= 0x2C0,
 	SIL_IDE3_CTL		= 0x2CA,
@@ -304,7 +310,7 @@
 	unsigned long base;
 	void *mmio_base;
 	int rc;
-	u32 tmp;
+	u32 tmp, irq_mask;
 
 	if (!printed_version++)
 		printk(KERN_DEBUG DRV_NAME " version " DRV_VERSION "\n");
@@ -365,14 +371,6 @@
 	probe_ent->port[1].scr_addr = base + SIL_IDE1_SCR;
 	ata_std_ports(&probe_ent->port[1]);
 
-	/* make sure IDE0/1 interrupts are not masked */
-	tmp = readl(mmio_base + SIL_SYSCFG);
-	if (tmp & (SIL_MASK_IDE0_INT | SIL_MASK_IDE1_INT)) {
-		tmp &= ~(SIL_MASK_IDE0_INT | SIL_MASK_IDE1_INT);
-		writel(tmp, mmio_base + SIL_SYSCFG);
-		readl(mmio_base + SIL_SYSCFG);	/* flush */
-	}
-
 	if (ent->driver_data == sil_3114) {
 		probe_ent->port[2].cmd_addr = base + SIL_IDE2_TF;
 		probe_ent->port[2].ctl_addr = base + SIL_IDE2_CTL;
@@ -385,6 +383,25 @@
 		probe_ent->port[3].bmdma_addr = base + SIL_IDE3_BMDMA;
 		probe_ent->port[3].scr_addr = base + SIL_IDE3_SCR;
 		ata_std_ports(&probe_ent->port[3]);
+
+		irq_mask = SIL_MASK_4PORT;
+
+		/* flip the magic "make 4 ports work" bit */
+		tmp = readl(mmio_base + SIL_IDE2_BMDMA);
+		if ((tmp & SIL_INTR_STEERING) == 0)
+			writel(tmp | SIL_INTR_STEERING,
+			       mmio_base + SIL_IDE2_BMDMA);
+
+	} else {
+		irq_mask = SIL_MASK_2PORT;
+	}
+
+	/* make sure IDE0/1/2/3 interrupts are not masked */
+	tmp = readl(mmio_base + SIL_SYSCFG);
+	if (tmp & irq_mask) {
+		tmp &= ~irq_mask;
+		writel(tmp, mmio_base + SIL_SYSCFG);
+		readl(mmio_base + SIL_SYSCFG);	/* flush */
 	}
 
 	pci_set_master(pdev);

Re: [PATCH] fix Silicon Image SATA 4-port support

[Stefan Smietanowski]

Hi Jeff.

> Do not be fooled, Silicon Image is still marked CONFIG_BROKEN for a 
> reason...  :)  But this should (hopefully!) get 4-port support going.
> 
> Testing requested...

Care to elaborate on what's left to do until you're satisfied with it?

And are the issues general (all chips) or specific to some chips?

// Stefan

Re: [PATCH] fix Silicon Image SATA 4-port support

[Jeff Garzik]

Stefan Smietanowski wrote:
> Hi Jeff.
> 
>> Do not be fooled, Silicon Image is still marked CONFIG_BROKEN for a 
>> reason...  :)  But this should (hopefully!) get 4-port support going.
>>
>> Testing requested...
> 
> 
> Care to elaborate on what's left to do until you're satisfied with it?
> 
> And are the issues general (all chips) or specific to some chips?


Just specific to Silicon Image, which is the only thing marked 
CONFIG_BROKEN.  It needs to acknowledge more interrupts than it 
currently does.

	Jeff

Re: [PATCH] fix Silicon Image SATA 4-port support

[Stefan Smietanowski]

Hi Jeff.

>>> Do not be fooled, Silicon Image is still marked CONFIG_BROKEN for a 
>>> reason...  :)  But this should (hopefully!) get 4-port support going.
>>>
>>> Testing requested...
>>
>> Care to elaborate on what's left to do until you're satisfied with it?
>>
>> And are the issues general (all chips) or specific to some chips?
> 
> Just specific to Silicon Image, which is the only thing marked 
> CONFIG_BROKEN.  It needs to acknowledge more interrupts than it 
> currently does.
> 
>     Jeff
> 
> 

Ok, the question was "specific to all SiI chips or only to some, or
maybe only to some boards or revisions" since it was about SiI...

But I take your second sentance to mean all chips and boards.

// Stefan

Re: [PATCH] fix Silicon Image SATA 4-port support

[Jeff Garzik]

Stefan Smietanowski wrote:
> Hi Jeff.
> 
>>>> Do not be fooled, Silicon Image is still marked CONFIG_BROKEN for a 
>>>> reason...  :)  But this should (hopefully!) get 4-port support going.
>>>>
>>>> Testing requested...
>>>
>>>
>>> Care to elaborate on what's left to do until you're satisfied with it?
>>>
>>> And are the issues general (all chips) or specific to some chips?
>>
>>
>> Just specific to Silicon Image, which is the only thing marked 
>> CONFIG_BROKEN.  It needs to acknowledge more interrupts than it 
>> currently does.
>>
>>     Jeff
>>
>>
> 
> Ok, the question was "specific to all SiI chips or only to some, or
> maybe only to some boards or revisions" since it was about SiI...
> 
> But I take your second sentance to mean all chips and boards.


All Silicon Image boards / chips.

	Jeff