From: Jeff Garzik <jgarzik@pobox.com>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IDE cleanups for 2.6.4-rc1 (2/3)
Date: Tue, 02 Mar 2004 18:08:24 -0500 [thread overview]
Message-ID: <404513E8.9010101@pobox.com> (raw)
In-Reply-To: <200403022215.07385.bzolnier@elka.pw.edu.pl>
Bartlomiej Zolnierkiewicz wrote:
> [IDE] remove ide_cmd_type_parser() logic
>
> Set ide_task_t fields (command_type, handler and prehandler) directly.
> Remove unused ide_task_t->posthandler and all ide_cmd_type_parser() logic.
>
> ide_cmd_type_parser() was meant to be used for ioctls but
> ended up checking validity of kernel generated requests (doh!).
>
> Rationale for removal:
> - it can't be used for existing ioctls (changes the way they work)
> - kernel shouldn't check validity of (root only) user-space requests
> (it can and should be done in user-space)
> - it wastes CPU cycles on going through parsers
> - it makes code harder to understand/follow
> (now info about request is localized)
Without the annoyingly-large 'switch', how do you figure out whether a
command is non-data, pio-read, pio-write, dma-read, or dma-write?
Jeff
next prev parent reply other threads:[~2004-03-02 23:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-02 21:15 [PATCH] IDE cleanups for 2.6.4-rc1 (2/3) Bartlomiej Zolnierkiewicz
2004-03-02 23:08 ` Jeff Garzik [this message]
2004-03-03 4:38 ` Bartlomiej Zolnierkiewicz
2004-03-03 4:41 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=404513E8.9010101@pobox.com \
--to=jgarzik@pobox.com \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).