* [PATCH] libata atapi work #2
@ 2004-05-14 1:34 Jeff Garzik
2004-05-14 12:44 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2004-05-14 1:34 UTC (permalink / raw)
To: linux-ide; +Cc: Pat LaVarre
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: patch.2 --]
[-- Type: text/plain, Size: 1282 bytes --]
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/05/13 21:15:42-04:00 jgarzik@redhat.com
# [libata] use new ->bmdma_{start,setup} method to properly support ATAPI
#
diff -Nru a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
--- a/drivers/scsi/libata-core.c Thu May 13 21:28:17 2004
+++ b/drivers/scsi/libata-core.c Thu May 13 21:28:17 2004
@@ -2445,7 +2445,7 @@
case ATA_PROT_DMA:
ap->ops->tf_load(ap, &qc->tf); /* load tf registers */
- ap->ops->bmdma_setup(qc); /* initiate bmdma */
+ ap->ops->bmdma_setup(qc); /* set up bmdma */
ap->ops->bmdma_start(qc); /* initiate bmdma */
break;
@@ -2457,6 +2457,13 @@
queue_work(ata_wq, &ap->pio_task);
break;
+ case ATA_PROT_ATAPI:
+ case ATA_PROT_ATAPI_DMA:
+ ap->ops->tf_load(ap, &qc->tf); /* load tf registers */
+ ap->ops->bmdma_setup(qc); /* set up bmdma */
+ queue_work(ata_wq, &ap->packet_task);
+ break;
+
default:
WARN_ON(1);
return -1;
@@ -2843,7 +2850,7 @@
/* if we are DMA'ing, irq handler takes over from here */
if (qc->tf.protocol == ATA_PROT_ATAPI_DMA) {
- /* FIXME: start DMA here */
+ ap->ops->bmdma_start(qc); /* initiate bmdma */
} else {
ap->pio_task_state = PIO_ST;
queue_work(ata_wq, &ap->pio_task);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libata atapi work #2
2004-05-14 1:34 [PATCH] libata atapi work #2 Jeff Garzik
@ 2004-05-14 12:44 ` Bartlomiej Zolnierkiewicz
2004-05-14 15:01 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2004-05-14 12:44 UTC (permalink / raw)
To: Jeff Garzik, linux-ide; +Cc: Pat LaVarre
Jeff, is this intentional?
@@ -2457,6 +2457,13 @@
queue_work(ata_wq, &ap->pio_task);
break;
+ case ATA_PROT_ATAPI:
+ case ATA_PROT_ATAPI_DMA:
+ ap->ops->tf_load(ap, &qc->tf); /* load tf registers */
+ ap->ops->bmdma_setup(qc); /* set up bmdma */
+ queue_work(ata_wq, &ap->packet_task);
+ break;
+
default:
WARN_ON(1);
return -1;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libata atapi work #2
2004-05-14 12:44 ` Bartlomiej Zolnierkiewicz
@ 2004-05-14 15:01 ` Jeff Garzik
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2004-05-14 15:01 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide, Pat LaVarre
Bartlomiej Zolnierkiewicz wrote:
> Jeff, is this intentional?
>
> @@ -2457,6 +2457,13 @@
> queue_work(ata_wq, &ap->pio_task);
> break;
>
> + case ATA_PROT_ATAPI:
> + case ATA_PROT_ATAPI_DMA:
> + ap->ops->tf_load(ap, &qc->tf); /* load tf registers */
> + ap->ops->bmdma_setup(qc); /* set up bmdma */
> + queue_work(ata_wq, &ap->packet_task);
> + break;
yeah, caught and fixed that...
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-05-14 15:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-05-14 1:34 [PATCH] libata atapi work #2 Jeff Garzik
2004-05-14 12:44 ` Bartlomiej Zolnierkiewicz
2004-05-14 15:01 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).