Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Hongyan Xu <getshell@seu.edu.cn>, Niklas Cassel <cassel@kernel.org>
Cc: linux-ide@vger.kernel.org, jianhao.xu@seu.edu.cn
Subject: Re: [PATCH] ata: pata_sl82c105: fix bridge revision use-after-free
Date: Thu, 6 Aug 2026 08:56:59 -0700	[thread overview]
Message-ID: <40d46bbe-bbb0-45d9-9a9c-e9e06fdb5ae7@kernel.org> (raw)
In-Reply-To: <20260806060628.1658-1-getshell@seu.edu.cn>

On 2026/08/05 23:06, Hongyan Xu wrote:
> pci_get_slot() returns a referenced PCI device. Commit 44c10138fd4b
> ("PCI: Change all drivers to use pci_device->revision") replaced a
> configuration-space read with direct access to the cached revision field,
> but left that access after pci_dev_put(). The bridge may therefore be freed
> before its revision is read.
> 
> Read the revision before dropping the reference.
> 
> Fixes: 44c10138fd4b ("PCI: Change all drivers to use pci_device->revision")
> Signed-off-by: Hongyan Xu <getshell@seu.edu.cn>

Applied to for-7.2-fixes. Thanks!

-- 
Damien Le Moal
Western Digital Research

      parent reply	other threads:[~2026-08-06 15:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06  6:06 [PATCH] ata: pata_sl82c105: fix bridge revision use-after-free Hongyan Xu
2026-08-06 11:55 ` Niklas Cassel
2026-08-06 15:56 ` Damien Le Moal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40d46bbe-bbb0-45d9-9a9c-e9e06fdb5ae7@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=cassel@kernel.org \
    --cc=getshell@seu.edu.cn \
    --cc=jianhao.xu@seu.edu.cn \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox