From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brad Campbell Subject: Re: [PATCH] libata ATA vs SATA detection and workaround. Date: Mon, 30 Aug 2004 20:34:43 +0400 Sender: linux-ide-owner@vger.kernel.org Message-ID: <41335723.40907@wasp.net.au> References: <41320DAF.2060306@wasp.net.au> <41321288.4090403@pobox.com> <413216CC.5080100@wasp.net.au> <4132198B.8000504@pobox.com> <41321F7F.7050300@pobox.com> <41333CDC.5040106@wasp.net.au> <41334058.4050902@wasp.net.au> <413350A2.1000003@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from wasp.net.au ([203.190.192.17]:3272 "EHLO wasp.net.au") by vger.kernel.org with ESMTP id S268165AbUH3QeL (ORCPT ); Mon, 30 Aug 2004 12:34:11 -0400 In-Reply-To: <413350A2.1000003@pobox.com> List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: linux-ide@vger.kernel.org, Linux Kernel , Alan Cox > I'm still pondering what Alan was hinting at, a bit. You (Brad) are > correct in pointing out that this code should only trigger for the > correct situations (lba48, etc.) which are only present on modern > drives, but... there is still a chance that word 93 will be zero on > some weird (probably non-compliant) device. I agree completely, though my feeling is that if someone plugs a device that broken into a SATA controller via a bridge then there "aint nuffin we can do about it" anyway and if it breaks it breaks. I guess we could offer the option you suggested before where we load the individual drivers as modules and provide a "knobble" module parm that will limit max_sectors to 200 and udma_mask to udma/100. Then we get the hassle if someone wants to use it as the root device, but I guess then you move to an initrd and load the module from there. How far do we want to take it? Regards, Brad