linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@elka.pw.edu.pl>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch][3/9] ide: add ide_sg_init() helper
Date: Wed, 08 Sep 2004 23:17:53 -0400	[thread overview]
Message-ID: <413FCB61.7060604@pobox.com> (raw)
In-Reply-To: <200409082126.49832.bzolnier@elka.pw.edu.pl>

Bartlomiej Zolnierkiewicz wrote:
> +static inline void ide_sg_init(struct scatterlist *sg, u8 *buf, unsigned int buflen)
> +{
> +	memset(sg, 0, sizeof(*sg));
> +
> +	sg->page = virt_to_page(buf);
> +	sg->offset = offset_in_page(buf);
> +	sg->length = buflen;
> +}
> +


Surely this should be more generic?

	Jeff



  reply	other threads:[~2004-09-09  3:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-08 19:26 [patch][3/9] ide: add ide_sg_init() helper Bartlomiej Zolnierkiewicz
2004-09-09  3:17 ` Jeff Garzik [this message]
2004-09-09 13:54   ` Bartlomiej Zolnierkiewicz
2004-09-09 14:47     ` Jens Axboe
2004-09-09 15:31       ` Bartlomiej Zolnierkiewicz
2004-09-09 15:38         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=413FCB61.7060604@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=bzolnier@elka.pw.edu.pl \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).