* [patch][0/6] ide: sanitize PIO code, take 2
@ 2004-09-10 22:26 Bartlomiej Zolnierkiewicz
2004-09-13 0:34 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2004-09-10 22:26 UTC (permalink / raw)
To: linux-ide, linux-kernel
Hi,
This patchkit:
- converts PIO code to use scatterlists instead of directly walking bios
- fixes longstanding 'data integrity on error' issue in non-taskfile PIO code
- unifies single/multiple PIO handling
- unifies taskfile/non-taskfile PIO handling
Changes:
- resync with -bk (first two patches are now merged)
- ide_sg_init() become generic init_sg_one() helper (linux/scatterlist.h)
(thanks to Jeff and Jens for suggestions)
- use init_sg_one() in Etrax IDE driver
- bugfix: use sg->length instead of sg_dma_len(sg)
(found thanks to rmk's concerns)
- uninline ide_pio_multi()
- make ide_pio_sector() and task_error() static
- drop removal of bio walking for now
Testing (esp. on non x86) and comments are welcomed.
BTW 'sanitize DMA' patchkit should be ready soon.
Bartlomiej
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch][0/6] ide: sanitize PIO code, take 2
2004-09-10 22:26 [patch][0/6] ide: sanitize PIO code, take 2 Bartlomiej Zolnierkiewicz
@ 2004-09-13 0:34 ` Jeff Garzik
2004-09-13 12:16 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2004-09-13 0:34 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide, linux-kernel, Russell King
Bartlomiej Zolnierkiewicz wrote:
> - bugfix: use sg->length instead of sg_dma_len(sg)
> (found thanks to rmk's concerns)
Details?
IIRC this breaks ia64 and/or other platforms?
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch][0/6] ide: sanitize PIO code, take 2
2004-09-13 0:34 ` Jeff Garzik
@ 2004-09-13 12:16 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2004-09-13 12:16 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-ide, linux-kernel, Russell King
On Monday 13 September 2004 02:34, Jeff Garzik wrote:
> Bartlomiej Zolnierkiewicz wrote:
> > - bugfix: use sg->length instead of sg_dma_len(sg)
> > (found thanks to rmk's concerns)
>
> Details?
Unlike libata we don't use DMA API for PIO.
> IIRC this breaks ia64 and/or other platforms?
No pci_[un]map_sg() so sg->length won't be ever changed.
Bartlomiej
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-09-13 14:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-10 22:26 [patch][0/6] ide: sanitize PIO code, take 2 Bartlomiej Zolnierkiewicz
2004-09-13 0:34 ` Jeff Garzik
2004-09-13 12:16 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).