From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: [PATCH] New QStor SATA/RAID Driver for 2.6.9-rc2 Date: Tue, 14 Sep 2004 22:39:22 -0400 Sender: linux-ide-owner@vger.kernel.org Message-ID: <4147AB5A.4060804@rtr.ca> References: <41471163.10709@rtr.ca> <414723B0.1090600@pobox.com> <1095186343.2008.29.camel@mulgrave> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from cpu1185.adsl.bellglobal.com ([207.236.110.166]:13977 "EHLO mail.rtr.ca") by vger.kernel.org with ESMTP id S266304AbUIOClA (ORCPT ); Tue, 14 Sep 2004 22:41:00 -0400 In-Reply-To: <1095186343.2008.29.camel@mulgrave> List-Id: linux-ide@vger.kernel.org To: James Bottomley Cc: Jeff Garzik , Mark Lord , Linux Kernel , SCSI Mailing List , "linux-ide@vger.kernel.org" , Alan Cox >Actually, its only wrong in queuecommand because that can be called in >softirq context. > >Sleeping in the eh paths is fine (as long as you drop the locks that the >EH thread has uselessly taken for you). Good, that's how I understood it as well. But the locking is certainly a mess as-is in the QStor driver. Sure, it is actually all technically correct, but hard to follow. I believe I can remove nearly all of it and really tidy things up as a result. Thanks guys, this has been really helpful so far. -- Mark Lord (hdparm keeper & the original "Linux IDE Guy")