From: Jeff Garzik <jgarzik@pobox.com>
To: Andy Warner <andyw@pobox.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: libata - error register patch.
Date: Mon, 04 Oct 2004 17:25:49 -0400 [thread overview]
Message-ID: <4161BFDD.1070509@pobox.com> (raw)
In-Reply-To: <20040929175011.L15041@florence.linkmargin.com>
Andy Warner wrote:
> It's entirely possible I'm missing something either
> very obvious, or very subtle, but I think the reading
> of the error register in libata et al is incorrect.
>
> Current code only reads the error register when
> in LBA48 mode, and then stores it in tf->hob_feature.
> Attached patch always reads it and stores it
> in tf->feature.
I'm still thinking about this one.
I need to check and see the behavior of this register, as we have a
separate ata_chk_err() as well.
Jeff
next prev parent reply other threads:[~2004-10-04 21:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-29 22:50 libata - error register patch Andy Warner
2004-10-04 21:25 ` Jeff Garzik [this message]
2004-10-04 21:44 ` Andy Warner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4161BFDD.1070509@pobox.com \
--to=jgarzik@pobox.com \
--cc=andyw@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).