From: Jeff Garzik <jgarzik@pobox.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Jens Axboe <axboe@suse.de>, Linux IDE <linux-ide@vger.kernel.org>
Subject: Re: libata vs ATAPI
Date: Fri, 15 Oct 2004 01:00:43 -0400 [thread overview]
Message-ID: <416F597B.5010801@pobox.com> (raw)
In-Reply-To: <58cb370e04101414157605d9a@mail.gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> [libata] fix INQUIRY command handling for ATAPI
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
applied to libata-dev-2.6.
> page = sg->page;
>
> should be here
>
> I also found the real bug (feature?): ata_scsi_rbuf_get() clears
> INQUIRY buffer for ATAPI when called from atapi_qc_complete().
>
> With the patch below INQUIRY w/ DMA works just fine for me
> ("Vendor" and "Model" are correctly reported).
Can you please resend your first patch,
1) assuming that this "fix INQUIRY command handling" patch is applied
2) removing the following piece of code:
+ if (scsicmd[0] == INQUIRY)
+ using_pio = 1;
Thanks,
Jeff
prev parent reply other threads:[~2004-10-15 5:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-12 20:21 libata vs ATAPI Bartlomiej Zolnierkiewicz
2004-10-12 20:50 ` Jeff Garzik
2004-10-12 21:17 ` Bartlomiej Zolnierkiewicz
2004-10-12 21:22 ` Jeff Garzik
2004-10-12 21:36 ` Bartlomiej Zolnierkiewicz
2004-10-12 21:45 ` Jeff Garzik
2004-10-12 23:03 ` Bartlomiej Zolnierkiewicz
2004-10-15 13:13 ` Jens Axboe
2004-10-15 17:17 ` Jeff Garzik
2004-10-12 21:30 ` Jeff Garzik
2004-10-12 21:39 ` Bartlomiej Zolnierkiewicz
2004-10-12 21:46 ` Jeff Garzik
2004-10-14 7:13 ` Jens Axboe
2004-10-14 19:19 ` Bartlomiej Zolnierkiewicz
2004-10-14 21:15 ` Bartlomiej Zolnierkiewicz
2004-10-15 5:00 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416F597B.5010801@pobox.com \
--to=jgarzik@pobox.com \
--cc=axboe@suse.de \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).