From: achew <achew@nvidia.com>
To: Jeff Garzik <jgarzik@pobox.com>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: [PATCH] sata_nv.c, don't have libata perform phy reset
Date: Fri, 05 Nov 2004 18:55:54 -0800 [thread overview]
Message-ID: <418C3D3A.6010501@nvidia.com> (raw)
This patch works around the issue reported in bug 3352 on the bugzilla bug database.
Link to the bug report: http://bugme.osdl.org/show_bug_cgi?id=3352
In particular, we keep libata from performing the phy reset. Doing the phy reset sometimes results in the busy bit failing to deassert.
Signed-off-by: Andrew Chew <achew@nvidia.com>
--- linux-2.6.10-rc1-bk15/drivers/scsi/sata_nv.c 2004-11-05 17:49:37.000000000 -0800
+++ linux/drivers/scsi/sata_nv.c 2004-11-05 17:55:48.000000000 -0800
@@ -20,6 +20,9 @@
* If you do not delete the provisions above, a recipient may use your
* version of this file under either the OSL or the GPL.
*
+ * 0.04
+ * - Disabled SATA phy reset to work around a problem where busy bit never
+ * deasserts after a phy reset.
* 0.03
* - Fixed a bug where the hotplug handlers for non-CK804/MCP04 were using
* mmio_base, which is only set for the CK804/MCP04 case.
@@ -44,7 +47,7 @@
#include <linux/libata.h>
#define DRV_NAME "sata_nv"
-#define DRV_VERSION "0.03"
+#define DRV_VERSION "0.04"
#define NV_PORTS 2
#define NV_PIO_MASK 0x1f
@@ -221,7 +224,6 @@
static struct ata_port_info nv_port_info = {
.sht = &nv_sht,
.host_flags = ATA_FLAG_SATA |
- ATA_FLAG_SATA_RESET |
ATA_FLAG_SRST |
ATA_FLAG_NO_LEGACY,
.pio_mask = NV_PIO_MASK,
next reply other threads:[~2004-11-06 2:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-06 2:55 achew [this message]
2004-11-06 17:09 ` [PATCH] sata_nv.c, don't have libata perform phy reset Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=418C3D3A.6010501@nvidia.com \
--to=achew@nvidia.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).