From mboxrd@z Thu Jan 1 00:00:00 1970 From: Douglas Gilbert Subject: Re: [patch libata-dev-2.6 1/1] libata: sync SMART ioctls with ATA pass thru spec (T10/04-262r7) Date: Thu, 03 Feb 2005 09:05:55 +1000 Message-ID: <42015CD3.60005@torque.net> Reply-To: dougg@torque.net Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Received: from borg.st.net.au ([65.23.158.22]:664 "EHLO borg.st.net.au") by vger.kernel.org with ESMTP id S262818AbVBBXGB (ORCPT ); Wed, 2 Feb 2005 18:06:01 -0500 Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: axboe@suse.de Cc: linville@tuxdriver.com, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Jens Axboe wrote: > > > > -/* Temporary values for T10/04-262 until official values are > allocated */ > > -#define ATA_16 0x85 /* 16-byte pass-thru > [0x85 == unused]*/ > -#define ATA_12 0xb3 /* 12-byte pass-thru > [0xb3 == obsolete set limits command] */ > > +/* Values for T10/04-262r7 */ > > +#define ATA_16 0x85 /* 16-byte pass-thru */ > > +#define ATA_12 0xa1 /* 12-byte pass-thru */ > > Ehh are you sure that is correct? 0xa1 is the BLANK command, I would > hate to think there would be a collision like that. That very point came up recently in a MMC meeting: http://www.t10.org/ftp/t10/document.05/05-056r0.pdf To confuse things further "ATA_16" is shown as opcode 0x98 in the latest draft of SPC-3 (rev 21c 15 January 2005) http://www.t10.org/ftp/t10/drafts/spc3/spc3r21c.pdf [annex D.3.1]. Hopefully these matters will be sorted out at the next t10 meeting in March. Doug Gilbert