From: Jeff Garzik <jgarzik@pobox.com>
To: Clear.Zhang@uli.com.tw
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
andrebalsa@mailingaddress.org, Peer.Chen@uli.com.tw,
Emily.Jiang@uli.com.tw, Eric.Lo@uli.com.tw
Subject: Re: [patch] scsi/libata: correct bug for ULi M5281
Date: Sat, 05 Feb 2005 23:43:33 -0500 [thread overview]
Message-ID: <4205A075.8090405@pobox.com> (raw)
In-Reply-To: <OF72031848.8565651F-ON48256F6A.0025361E@uli.com.tw>
Clear.Zhang@uli.com.tw wrote:
> Hi Jeff,
>
> I've correct the patch according to your suggestion.
> But we need libata-core.c to export some functions.
> Here is the patch. Please check it and apply it to new kernels.
> Thanks a lot.
I'm afraid I cannot accept even the updated version of your patch.
Your second patch updates libata-core, and adds ULi-specific code to it.
What we need to do is
1) determine if your problem is ULi-specific, or applies to other
controllers
2a) If the problem is not ULi-specific, simply update libata to new
behavior.
2b) If the problem is ULi-specific, libata must be modified such that
all ULi-specific reset procedures are in sata_uli.c, and _no code is
duplicated from libata_. This may require that we change the libata
API. In Linux, it is OK to change the driver API when there is a problem :)
Regards,
Jeff
next parent reply other threads:[~2005-02-06 4:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <OF72031848.8565651F-ON48256F6A.0025361E@uli.com.tw>
2005-02-06 4:43 ` Jeff Garzik [this message]
[not found] <OF934C846F.FCC47C36-ON48256FA0.0024A886@uli.com.tw>
2005-02-06 7:08 ` [patch] scsi/libata: correct bug for ULi M5281 Jeff Garzik
2004-12-08 6:45 Clear.Zhang
2004-12-11 19:15 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4205A075.8090405@pobox.com \
--to=jgarzik@pobox.com \
--cc=Clear.Zhang@uli.com.tw \
--cc=Emily.Jiang@uli.com.tw \
--cc=Eric.Lo@uli.com.tw \
--cc=Peer.Chen@uli.com.tw \
--cc=andrebalsa@mailingaddress.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).