From: Tejun Heo <htejun@gmail.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Tejun Heo <tj@home-tj.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.11-rc2 05/09] ide: map ide_task_ioctl() to ide_taskfile_ioctl()
Date: Mon, 07 Feb 2005 14:04:25 +0900 [thread overview]
Message-ID: <4206F6D9.6050700@gmail.com> (raw)
In-Reply-To: <58cb370e050206103817d11145@mail.gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> On Sat, 5 Feb 2005 11:15:56 +0900 (KST), Tejun Heo <tj@home-tj.org> wrote:
>
>
>>- int err = 0;
>>- u8 args[7], *argbuf = args;
>>- int argsize = 7;
>>+ u8 args[7];
>>+ ide_task_t task;
>>+ task_ioreg_t *regs = task.tfRegister;
>
>
> u8 *regs please
>
Sure.
>
>>+ int ret;
>
>
> What is the reason for changing the name of variable
> (other than making the patch bigger ;) ?
Heh, Heh, I thought I could get away with it.
I'll restore it. :-)
> Please also read comments to patch #4.
Thanks.
--
tejun
next prev parent reply other threads:[~2005-02-07 5:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-05 2:15 [PATCH 2.6.11-rc2] ide: driver updates (phase 2) Tejun Heo
2005-02-05 9:53 ` Tejun Heo
2005-02-05 10:14 ` Tejun Heo
[not found] ` <20050205021555.F3D161326FA@htj.dyndns.org>
2005-02-06 13:20 ` [PATCH 2.6.11-rc2 01/09] ide: kill unused pkt_task_t Bartlomiej Zolnierkiewicz
[not found] ` <20050205021556.8FC05132701@htj.dyndns.org>
2005-02-06 18:34 ` [PATCH 2.6.11-rc2 04/09] ide: convert REQ_DRIVE_TASK to REQ_DRIVE_TASKFILE Bartlomiej Zolnierkiewicz
2005-02-07 5:13 ` Tejun Heo
[not found] ` <20050205021556.CFCE41326F9@htj.dyndns.org>
2005-02-06 18:38 ` [PATCH 2.6.11-rc2 05/09] ide: map ide_task_ioctl() to ide_taskfile_ioctl() Bartlomiej Zolnierkiewicz
2005-02-07 5:04 ` Tejun Heo [this message]
[not found] ` <20050205021557.6A692132705@htj.dyndns.org>
2005-02-06 18:46 ` [PATCH 2.6.11-rc2 08/09] ide: map ide_cmd_ioctl() " Bartlomiej Zolnierkiewicz
2005-02-07 5:02 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2005-02-05 10:25 [PATCH REPOST 2.6.11-rc2] ide: driver updates (phase 2) Tejun Heo
2005-02-05 10:28 ` [PATCH 2.6.11-rc2 05/09] ide: map ide_task_ioctl() to ide_taskfile_ioctl() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4206F6D9.6050700@gmail.com \
--to=htejun@gmail.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@home-tj.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).