From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [rfc][patch] ide: fix unneeded LBA48 taskfile registers access Date: Wed, 09 Feb 2005 21:04:40 -0500 Message-ID: <420AC138.1060005@pobox.com> References: <4206F2E5.7020501@gmail.com> <200502070959.54973.bzolnier@elka.pw.edu.pl> <420AA476.1040406@gmail.com> <58cb370e050209162437808733@mail.gmail.com> <420AB049.4040705@gmail.com> <58cb370e05020917312994f531@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:35716 "EHLO parcelfarce.linux.theplanet.co.uk") by vger.kernel.org with ESMTP id S262009AbVBJCFD (ORCPT ); Wed, 9 Feb 2005 21:05:03 -0500 In-Reply-To: <58cb370e05020917312994f531@mail.gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: Tejun Heo , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Alan Cox Bartlomiej Zolnierkiewicz wrote: > On Thu, 10 Feb 2005 09:52:25 +0900, Tejun Heo wrote: > >> Okay, another quick question. >> >> To fix the io_32bit race problem in ide_taskfile_ioctl() (and later >>ide_cmd_ioctl() too), it seems simplest to mark the taskfile with >>something like ATA_TFLAG_IO_16BIT flag and use the flag in task_in_intr(). >> >> However, ATA_TFLAG_* are used by libata, and I think that, although >>sharing hardware constants is good if the hardware is similar, sharing >>driver-specific flags isn't such a good idea. So, what do you think? >> >> 1. Add ATA_TFLAG_IO_16BIT to ata.h >> 2. Make ide's own set of task flags, maybe IDE_TFLAG_* (including >> IDE_TFLAG_LBA48) > > > Please add it to (unless Jeff complains loudly), > I have a patch converting ide_task_t to use struct ata_taskfile > (except ->protocol for now). ACK