From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prakash Punnoor Subject: Re: [BK PATCHES] 2.6.x libata fixes (mostly) Date: Wed, 23 Feb 2005 23:07:31 +0100 Message-ID: <421CFEA3.6000207@arcor.de> References: <421CE018.5030007@pobox.com> <200502232345.23666.adobriyan@mail.ru> <421CF575.20801@arcor.de> <528y5faqbb.fsf@topspin.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigEB3B400014431A70F3978E05" In-Reply-To: <528y5faqbb.fsf@topspin.com> Sender: linux-kernel-owner@vger.kernel.org To: Roland Dreier Cc: Alexey Dobriyan , Jeff Garzik , Andrew Morton , Linus Torvalds , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Lord List-Id: linux-ide@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigEB3B400014431A70F3978E05 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Roland Dreier schrieb: > Prakash> If I am not totally mistaken this is not gcc4 friendly > Prakash> code. (lvalue thing...) > > Actually you misread the code slightly. It's a little subtle, but > code like > > *(__le32 *)prd = cpu_to_le32(len); > > is not using a cast as an lvalue. It's dereferencing a cast and as > such is totally correct, idiomatic and clean C. OK, thanks for clearing that up. Obviously my C knowledge needs to be improved... -- Prakash Punnoor formerly known as Prakash K. Cheemplavam --------------enigEB3B400014431A70F3978E05 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (GNU/Linux) iD8DBQFCHP6jxU2n/+9+t5gRAmsKAJ9wD9iCmwul3rypinb/ycQFaw2cpQCeOrOM oyVStwkKdej1fR8VkGct9PI= =MyVF -----END PGP SIGNATURE----- --------------enigEB3B400014431A70F3978E05--