From: Albert Lee <albertcc@tw.ibm.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: IDE Linux <linux-ide@vger.kernel.org>
Subject: [PATCH libata-dev-2.6] ata_scsi_verify_xlat() fix
Date: Thu, 24 Feb 2005 15:12:26 +0800 [thread overview]
Message-ID: <421D7E5A.80702@tw.ibm.com> (raw)
Jeff,
Attached please find the split ata_scsi_verify_xlat() fix.
Change:
- Fix uninitialized tf->command bug in ata_scsi_verify_xlat(), introduced by my previous CHS support patch.
(This is similar to http://marc.theaimsgroup.com/?l=linux-ide&m=110735039505617&w=2)
- Fix comment wording.
The patch is against libata-dev-2.6 tree for your review.
Albert
Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
=============================================================================================
--- libata-dev-2.6/drivers/scsi/libata-scsi.c 2005-02-21 17:23:03.000000000 +0800
+++ libata-dev-2.6-mod/drivers/scsi/libata-scsi.c 2005-02-22 18:32:19.000000000 +0800
@@ -785,6 +785,7 @@
if ((cyl >> 16) || (head >> 4) || (sect >> 8) || (!sect))
return 1;
+ tf->command = ATA_CMD_VERIFY;
tf->nsect = n_block & 0xff; /* Sector count 0 means 256 sectors */
tf->lbal = sect;
tf->lbam = cyl;
@@ -875,7 +876,7 @@
/* Check and compose ATA command */
if (!n_block)
- /* In ATA, sector count 0 are 256 or 65536 sectors, not 0 sectors. */
+ /* In ATA, sector count 0 means 256 or 65536 sectors, not 0 sectors. */
return 1;
if (lba) {
next reply other threads:[~2005-02-24 7:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-24 7:12 Albert Lee [this message]
2005-02-24 7:44 ` [PATCH libata-dev-2.6] ata_scsi_verify_xlat() fix Jeff Garzik
2005-02-25 4:58 ` Albert Lee
2005-02-25 5:28 ` Jeff Garzik
2005-02-25 7:52 ` Albert Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=421D7E5A.80702@tw.ibm.com \
--to=albertcc@tw.ibm.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).