[PATCH libata-2.6] AHCI: print port ID not number

[PATCH libata-2.6] AHCI: print port ID not number

[Brett Russ]

The attached patch fixes the "ata#: error occurred, port reset" line
to display the port id instead of the port number.

Signed-off-by: Brett Russ <russb@emc.com>

--- libata-2.6/drivers/scsi/ahci.c	Thu Feb 24 14:18:35 2005
+++ libata-2.6-ahci-printk/drivers/scsi/ahci.c	Thu Feb 24 14:21:41 2005
@@ -574,7 +574,7 @@
 	writel(tmp, port_mmio + PORT_CMD);
 	readl(port_mmio + PORT_CMD); /* flush */
 
-	printk(KERN_WARNING "ata%u: error occurred, port reset\n", ap->port_no);
+	printk(KERN_WARNING "ata%u: error occurred, port reset\n", ap->id);
 }
 
 static void ahci_eng_timeout(struct ata_port *ap)

Re: [PATCH libata-2.6] AHCI: print port ID not number

[Jeff Garzik]

Brett Russ wrote:
> The attached patch fixes the "ata#: error occurred, port reset" line
> to display the port id instead of the port number.
> 
> Signed-off-by: Brett Russ <russb@emc.com>
> 
> --- libata-2.6/drivers/scsi/ahci.c	Thu Feb 24 14:18:35 2005
> +++ libata-2.6-ahci-printk/drivers/scsi/ahci.c	Thu Feb 24 14:21:41 2005
> @@ -574,7 +574,7 @@
>  	writel(tmp, port_mmio + PORT_CMD);
>  	readl(port_mmio + PORT_CMD); /* flush */
>  
> -	printk(KERN_WARNING "ata%u: error occurred, port reset\n", ap->port_no);
> +	printk(KERN_WARNING "ata%u: error occurred, port reset\n", ap->id);

I applied this manually a little while ago, but in any case,

I verified that this patch applies correctly and successfully, so your 
patch submissions are coming in loud-and-clear now.

Thanks,

	Jeff

[PATCH libata-2.6] AHCI: print port ID not number

[Brett Russ]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

The attached patch fixes the "ata#: error occurred, port reset" line to 
display the port id instead of the port number.

Signed-off-by: Brett Russ <russb@emc.com>

[-- Attachment #2: libata-2.6-ahci-printk.diff --]
[-- Type: text/x-patch, Size: 463 bytes --]

--- libata-2.6/drivers/scsi/ahci.c      Thu Feb 24 14:18:35 2005
+++ libata-2.6-ahci-printk/drivers/scsi/ahci.c  Thu Feb 24 14:21:41 2005
@@ -574,7 +574,7 @@
        writel(tmp, port_mmio + PORT_CMD);
        readl(port_mmio + PORT_CMD); /* flush */

-       printk(KERN_WARNING "ata%u: error occurred, port reset\n", ap->port_no);
+       printk(KERN_WARNING "ata%u: error occurred, port reset\n", ap->id);
 }

 static void ahci_eng_timeout(struct ata_port *ap)

Re: [PATCH libata-2.6] AHCI: print port ID not number

[Jeff Garzik]

Brett Russ wrote:
> The attached patch fixes the "ata#: error occurred, port reset" line to 
> display the port id instead of the port number.
> 
> Signed-off-by: Brett Russ <russb@emc.com>
> 
> 
> ------------------------------------------------------------------------
> 
> --- libata-2.6/drivers/scsi/ahci.c      Thu Feb 24 14:18:35 2005
> +++ libata-2.6-ahci-printk/drivers/scsi/ahci.c  Thu Feb 24 14:21:41 2005
> @@ -574,7 +574,7 @@
>         writel(tmp, port_mmio + PORT_CMD);
>         readl(port_mmio + PORT_CMD); /* flush */
> 
> -       printk(KERN_WARNING "ata%u: error occurred, port reset\n", ap->port_no);
> +       printk(KERN_WARNING "ata%u: error occurred, port reset\n", ap->id);

Your patch is corrupted, as <something> converted tabs to spaces.

I highly recommend finding a Unix machine with sendmail, and sending 
patches like this:

The ideal is an inline patch, rather than an attachment anyway.  e.g.

To: ...
From: ...
Subject: ...
<blank line>
Patch description
Patch

cat'd to 'sendmail -t'.  Sendmail (or another MTA which provides a 
/usr/sbin/sendmail wrapper) will automatically fill in other headers 
like Message-ID and Date.

	Jeff