From: Jeff Garzik <jgarzik@pobox.com>
To: Henning Schmiedehausen <hps@intermeta.de>
Cc: Linux IDE Mailingliste <linux-ide@vger.kernel.org>
Subject: Re: PCI Constants Update for SATA Driver
Date: Sun, 27 Feb 2005 13:08:42 -0500 [thread overview]
Message-ID: <42220CAA.90702@pobox.com> (raw)
In-Reply-To: <1109526163.19325.2.camel@forge.intermeta.de>
Henning Schmiedehausen wrote:
> Hi,
>
> having the various constants in pci_ids.h is a really good thing for
> grepping through the kernel source. And if they were used, it would be
> even better (if you e.g. are looking for which driver claims an SIImage
> 3112 card...). However, the sata_xxx.c files in the drivers/scsi
> directory are notorious for not using the PCI Ids but just hard coded
> numbers.
>
> This patch tries to fix this. It is against the 2.6.10 tree from Fedora
> Core 3 but should apply to a regular 2.6.10 too.
"Notorious", heh. This is quite intentional.
PCI device ids are just random numbers that vendors pick out of thin
air. Device id symbolic constants have little value, and creates churn
whereby every kernel hacker is patching include/linux/pci_ids.h.
Jeff
next prev parent reply other threads:[~2005-02-27 18:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-27 17:42 PCI Constants Update for SATA Driver Henning Schmiedehausen
2005-02-27 18:08 ` Jeff Garzik [this message]
2005-02-27 19:20 ` Henning Schmiedehausen
2005-02-27 19:52 ` Jeff Garzik
2005-02-27 20:05 ` Henning Schmiedehausen
2005-02-27 20:07 ` Jeff Garzik
2005-03-02 1:47 ` Benjamin Herrenschmidt
2005-03-02 5:49 ` Jeff Garzik
2005-03-02 1:46 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42220CAA.90702@pobox.com \
--to=jgarzik@pobox.com \
--cc=hps@intermeta.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).