From: Albert Lee <albertcc@tw.ibm.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Linux IDE <linux-ide@vger.kernel.org>
Subject: [PATCH ide-2.6] pdc202xx_new: Enable ATAPI DMA
Date: Tue, 08 Mar 2005 18:50:15 +0800 [thread overview]
Message-ID: <422D8367.1050606@tw.ibm.com> (raw)
Hi Bart,
These is the patch to turn on pdc202xx_new for ATAPI DMA.
When testing, it works fine without the (request_bufflen % 256) workaround as needed in libata.
ide-scsi filters out (pc->request_transfer % 1024) and use PIO, so the pdc202xx ATAPI DMA problem is avoid.
Both ide-cd and ide-scsi won't hit the ATAPI DMA problem on pdc202xx_new.
Changes:
- Turn on ATAPI DMA for pdc202xx_new
Attached please find the patch against the ide-2.6 tree for your review. Thanks.
Albert
Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
-------
diff -Nru libata-dev-2.6-hwauto/drivers/ide/pci/pdc202xx_new.c libata-dev-2.6-atapidma/drivers/ide/pci/pdc202xx_new.c
--- libata-dev-2.6-hwauto/drivers/ide/pci/pdc202xx_new.c 2005-03-07 18:19:06.000000000 +0800
+++ libata-dev-2.6-atapidma/drivers/ide/pci/pdc202xx_new.c 2005-03-08 18:34:23.000000000 +0800
@@ -290,7 +290,8 @@
printk(KERN_WARNING "%s reduced to Ultra33 mode.\n", drive->name);
}
- if (drive->media != ide_disk)
+ if (drive->media != ide_disk &&
+ drive->media != ide_cdrom)
return 0;
if (id->capability & 4) { /* IORDY_EN & PREFETCH_EN */
@@ -633,6 +634,7 @@
hwif->drives[0].autotune = hwif->drives[1].autotune = 1;
+ hwif->atapi_dma = 1;
hwif->ultra_mask = 0x7f;
hwif->mwdma_mask = 0x07;
reply other threads:[~2005-03-08 10:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=422D8367.1050606@tw.ibm.com \
--to=albertcc@tw.ibm.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).