* [PATCH libata-2.6] AHCI: fix fatal error int handling
@ 2005-03-09 20:57 Brett Russ
2005-03-10 5:45 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Brett Russ @ 2005-03-09 20:57 UTC (permalink / raw)
To: linux-ide, linux-kernel
I noticed that the AHCI CI (cmd issue) reg wasn't getting cleared
after error ints resulting in no further commands being successfully
issued to the port. This patch fixes. All that's really needed is
the 1's complement but I also removed the disabling/enabling of the
FIS_RX b/c this isn't spec'd as necessary when handling error ints.
Signed-off-by: Brett Russ <russb@emc.com>
===== drivers/scsi/ahci.c 1.17 vs edited =====
--- 1.17/drivers/scsi/ahci.c 2005-02-24 14:52:41 -05:00
+++ edited/drivers/scsi/ahci.c 2005-03-09 15:30:06 -05:00
@@ -538,7 +538,7 @@
/* stop DMA */
tmp = readl(port_mmio + PORT_CMD);
- tmp &= PORT_CMD_START | PORT_CMD_FIS_RX;
+ tmp &= ~PORT_CMD_START;
writel(tmp, port_mmio + PORT_CMD);
/* wait for engine to stop. TODO: this could be
@@ -570,7 +570,7 @@
/* re-start DMA */
tmp = readl(port_mmio + PORT_CMD);
- tmp |= PORT_CMD_START | PORT_CMD_FIS_RX;
+ tmp |= PORT_CMD_START;
writel(tmp, port_mmio + PORT_CMD);
readl(port_mmio + PORT_CMD); /* flush */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH libata-2.6] AHCI: fix fatal error int handling
2005-03-09 20:57 [PATCH libata-2.6] AHCI: fix fatal error int handling Brett Russ
@ 2005-03-10 5:45 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2005-03-10 5:45 UTC (permalink / raw)
To: Brett Russ; +Cc: linux-ide, linux-kernel
Brett Russ wrote:
> I noticed that the AHCI CI (cmd issue) reg wasn't getting cleared
> after error ints resulting in no further commands being successfully
> issued to the port. This patch fixes. All that's really needed is
> the 1's complement but I also removed the disabling/enabling of the
> FIS_RX b/c this isn't spec'd as necessary when handling error ints.
>
> Signed-off-by: Brett Russ <russb@emc.com>
Thanks, applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-03-10 5:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-09 20:57 [PATCH libata-2.6] AHCI: fix fatal error int handling Brett Russ
2005-03-10 5:45 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).