From: Jeff Garzik <jgarzik@pobox.com>
To: Albert Lee <albertcc@tw.ibm.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Doug Maxey <dwm@maxeymade.com>,
Linux IDE <linux-ide@vger.kernel.org>
Subject: Re: PATCH libata-2.6 4/5] Prevent the device from overrunning the buffer in __atapi_pio_bytes()
Date: Tue, 22 Mar 2005 14:11:52 -0500 [thread overview]
Message-ID: <42406DF8.6050504@pobox.com> (raw)
In-Reply-To: <423A9989.7050008@tw.ibm.com>
Albert Lee wrote:
> >
> > Bartlomiej Zolnierkiewicz wrote:
>
>>>
>>> Problem:
>>> Some bad behaved CD-ROM drives will return more data than ask to.
>>> (I have such CD-RW drive and it crashed the kernel.)
>>
>>
>>
>> These devices are compliant with original ATAPI spec.
>>
>> Such condition shouldn't be treated as an error
>> - extra data should be read and dumped.
>>
>>
> Hi Bart,
>
> For read, we can read and discard the extra data from the device.
> For write, the device is asking for more data than we have.
> Should we supply some dummy data to the device? Or we just stop and
> return it as error?
For write, we need to pad. For DMA, we need to add additional zeroes,
until the DMA transfer ends on a dword boundary. For PIO, we must at
least pad to a word boundary.
Jeff
next prev parent reply other threads:[~2005-03-22 19:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-18 8:00 PATCH libata-2.6 4/5] Prevent the device from overrunning the buffer in __atapi_pio_bytes() Albert Lee
2005-03-18 8:31 ` Bartlomiej Zolnierkiewicz
2005-03-18 9:04 ` Albert Lee
2005-03-22 19:11 ` Jeff Garzik [this message]
2005-03-29 12:41 ` Albert Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42406DF8.6050504@pobox.com \
--to=jgarzik@pobox.com \
--cc=albertcc@tw.ibm.com \
--cc=bzolnier@gmail.com \
--cc=dwm@maxeymade.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).