From: "Eric A. Cottrell" <eac@shore.net>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Linux IDE <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 2.6.12-rc2 1/2] libata: add missing read of error register
Date: Sat, 16 Apr 2005 21:54:55 -0400 [thread overview]
Message-ID: <4261C1EF.9060708@shore.net> (raw)
Hello Jeff,
Problem:
The feature member is not being set from the error register when the taskfile is read. This causes a problem when the task file is
read to determine errors.
Solution:
In libata-core.c add code to set the feature member in the taskfile structure.
Signed-off-by: Eric A. Cottrell eac@shore.net
--- a/drivers/scsi/libata-core.c 2005-04-09 19:34:19.000000000 -0400
+++ b/drivers/scsi/libata-core.c 2005-04-16 18:10:39.000000000 -0400
@@ -261,6 +261,7 @@
{
struct ata_ioports *ioaddr = &ap->ioaddr;
+ tf->feature = inb(ioaddr->error_addr);
tf->nsect = inb(ioaddr->nsect_addr);
tf->lbal = inb(ioaddr->lbal_addr);
tf->lbam = inb(ioaddr->lbam_addr);
@@ -293,6 +294,7 @@
{
struct ata_ioports *ioaddr = &ap->ioaddr;
+ tf->feature = readb((void __iomem *)ioaddr->error_addr);
tf->nsect = readb((void __iomem *)ioaddr->nsect_addr);
tf->lbal = readb((void __iomem *)ioaddr->lbal_addr);
tf->lbam = readb((void __iomem *)ioaddr->lbam_addr);
reply other threads:[~2005-04-17 1:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4261C1EF.9060708@shore.net \
--to=eac@shore.net \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).