* Re: [PATCH 2.6.12-rc2 1/2] libata: add missing read of error register
@ 2005-04-17 1:54 Eric A. Cottrell
0 siblings, 0 replies; only message in thread
From: Eric A. Cottrell @ 2005-04-17 1:54 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Linux IDE
Hello Jeff,
Problem:
The feature member is not being set from the error register when the taskfile is read. This causes a problem when the task file is
read to determine errors.
Solution:
In libata-core.c add code to set the feature member in the taskfile structure.
Signed-off-by: Eric A. Cottrell eac@shore.net
--- a/drivers/scsi/libata-core.c 2005-04-09 19:34:19.000000000 -0400
+++ b/drivers/scsi/libata-core.c 2005-04-16 18:10:39.000000000 -0400
@@ -261,6 +261,7 @@
{
struct ata_ioports *ioaddr = &ap->ioaddr;
+ tf->feature = inb(ioaddr->error_addr);
tf->nsect = inb(ioaddr->nsect_addr);
tf->lbal = inb(ioaddr->lbal_addr);
tf->lbam = inb(ioaddr->lbam_addr);
@@ -293,6 +294,7 @@
{
struct ata_ioports *ioaddr = &ap->ioaddr;
+ tf->feature = readb((void __iomem *)ioaddr->error_addr);
tf->nsect = readb((void __iomem *)ioaddr->nsect_addr);
tf->lbal = readb((void __iomem *)ioaddr->lbal_addr);
tf->lbam = readb((void __iomem *)ioaddr->lbam_addr);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-04-17 1:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-17 1:54 [PATCH 2.6.12-rc2 1/2] libata: add missing read of error register Eric A. Cottrell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).