From: Jeff Garzik <jgarzik@pobox.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Jens Axboe <axboe@suse.de>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SATA NCQ #3
Date: Tue, 31 May 2005 12:49:19 -0400 [thread overview]
Message-ID: <429C958F.7090700@pobox.com> (raw)
In-Reply-To: <429C90DE.3000106@tls.msk.ru>
Michael Tokarev wrote:
> Jeff Garzik wrote:
> []
>
>>
>> struct ahci_host_priv {
>> unsigned long flags;
>>+ unsigned int have_msi; /* is PCI MSI enabled? */
>
>
> BTW, can `have_msi' be just another bit in the `flags' field?
Yes, that would be a good cleanup to make.
Wanna submit a patch adding HOST_CAP_MSI bit?
Jeff
prev parent reply other threads:[~2005-05-31 16:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-31 12:47 [PATCH] SATA NCQ #3 Jens Axboe
2005-05-31 15:05 ` Jeff Garzik
2005-05-31 15:07 ` Jens Axboe
2005-05-31 15:45 ` Jeff Garzik
2005-05-31 15:48 ` Jens Axboe
2005-05-31 16:29 ` Michael Tokarev
2005-05-31 16:49 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=429C958F.7090700@pobox.com \
--to=jgarzik@pobox.com \
--cc=axboe@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjt@tls.msk.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).