From: Albert Lee <albertcc@tw.ibm.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Linux IDE <linux-ide@vger.kernel.org>,
Doug Maxey <dwm@maxeymade.com>
Subject: Re: [PATCH 2/4] if condition fix for __atapi_pio_bytes()
Date: Wed, 08 Jun 2005 11:47:44 +0800 [thread overview]
Message-ID: <42A66A60.5060105@tw.ibm.com> (raw)
In-Reply-To: <58cb370e050606023238eeecba@mail.gmail.com>
Hi Bart:
>
>
> (bytes > qc->nbytes) condition can happen and this part of the patch
> is fine with me
> but I fail to see how (qc->cursg_ofs > sg->length) or (count > bytes)
> can happen...
>
> count = min(sg->length - qc->cursg_ofs, bytes);
>
> /* don't cross page boundaries */
> count = min(count, (unsigned int)PAGE_SIZE - offset);
>
> Bartlomiej
>
>
Normally (qc->cursg_ofs > sg->length) or (count > bytes) won't happen.
However, if we apply patch [4/4], which overrun the odd-length buffer by one byte,
then (qc->cursg_ofs > sg->length) and (count > bytes) could happen.
Albert
next prev parent reply other threads:[~2005-06-08 3:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-06 7:47 [PATCH 0/4] Resubmit ATAPI PIO mode fixes Albert Lee
2005-06-06 7:56 ` [PATCH 1/4] sg traverse fix for __atapi_pio_bytes() Albert Lee
2005-06-06 9:24 ` Bartlomiej Zolnierkiewicz
2005-06-06 7:58 ` [PATCH 2/4] if condition " Albert Lee
2005-06-06 9:32 ` Bartlomiej Zolnierkiewicz
2005-06-08 3:47 ` Albert Lee [this message]
2005-06-08 9:48 ` Bartlomiej Zolnierkiewicz
2005-06-08 11:58 ` Albert Lee
2005-06-08 13:33 ` Bartlomiej Zolnierkiewicz
2005-06-09 4:05 ` Albert Lee
2005-06-09 6:54 ` Bartlomiej Zolnierkiewicz
2005-06-08 13:39 ` Bartlomiej Zolnierkiewicz
2005-06-06 7:59 ` [PATCH 3/4] trailing data handling " Albert Lee
2005-06-06 9:37 ` Bartlomiej Zolnierkiewicz
2005-06-06 8:01 ` [PATCH 4/4] odd length data handling " Albert Lee
2005-06-06 9:39 ` Bartlomiej Zolnierkiewicz
[not found] ` <42A7ED91.4090008@pobox.com>
2005-06-10 6:08 ` [PATCH 0/4] Resubmit ATAPI PIO mode fixes Albert Lee
2005-06-10 7:38 ` [PATCH 2/4] libata: if condition fix for __atapi_pio_bytes() Albert Lee
2005-06-10 7:56 ` Bartlomiej Zolnierkiewicz
2005-06-10 8:31 ` Albert Lee
2005-06-10 7:44 ` [PATCH 3/4] libata: trailing data handling " Albert Lee
2005-06-10 7:46 ` [PATCH 4/4] libata: odd length data handling " Albert Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42A66A60.5060105@tw.ibm.com \
--to=albertcc@tw.ibm.com \
--cc=bzolnier@gmail.com \
--cc=dwm@maxeymade.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).