From: Albert Lee <albertcc@tw.ibm.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Linux IDE <linux-ide@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Doug Maxey <dwm@maxeymade.com>
Subject: [PATCH 3/4] libata: trailing data handling fix for __atapi_pio_bytes()
Date: Fri, 10 Jun 2005 15:44:20 +0800 [thread overview]
Message-ID: <42A944D4.3030100@tw.ibm.com> (raw)
In-Reply-To: <42A7ED91.4090008@pobox.com>
[-- Attachment #1: Type: text/plain, Size: 245 bytes --]
Hi Jeff,
Resend the patch #3.
Problem:
Sometimes CD-ROM drives will ask/return more data than expected.
Changes:
- Handle the trailing data if the end of qc->sg has been reached.
Albert
Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
[-- Attachment #2: 03_trailing_data.diff --]
[-- Type: text/plain, Size: 738 bytes --]
--- 12_atapi_pio_if_condition_fix/drivers/scsi/libata-core.c 2005-06-06 13:52:11.000000000 +0800
+++ 13_atapi_pio_trailing_data_handling/drivers/scsi/libata-core.c 2005-06-09 11:05:10.000000000 +0800
@@ -2575,6 +2575,23 @@
ap->pio_task_state = PIO_ST_LAST;
next_sg:
+ /* check whether qc->sg is full */
+ if (unlikely(qc->cursg >= qc->n_elem)) {
+ unsigned char pad_buf[2];
+ unsigned int words = bytes >> 1;
+ unsigned int i;
+
+ DPRINTK("ata%u: padding %u bytes\n", ap->id, bytes);
+
+ memset(&pad_buf, 0, sizeof(pad_buf));
+ for (i = 0; i < words; i++) {
+ ata_data_xfer(ap, pad_buf, sizeof(pad_buf), do_write);
+ }
+
+ ap->pio_task_state = PIO_ST_LAST;
+ return;
+ }
+
sg = &qc->sg[qc->cursg];
page = sg->page;
next prev parent reply other threads:[~2005-06-10 7:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-06 7:47 [PATCH 0/4] Resubmit ATAPI PIO mode fixes Albert Lee
2005-06-06 7:56 ` [PATCH 1/4] sg traverse fix for __atapi_pio_bytes() Albert Lee
2005-06-06 9:24 ` Bartlomiej Zolnierkiewicz
2005-06-06 7:58 ` [PATCH 2/4] if condition " Albert Lee
2005-06-06 9:32 ` Bartlomiej Zolnierkiewicz
2005-06-08 3:47 ` Albert Lee
2005-06-08 9:48 ` Bartlomiej Zolnierkiewicz
2005-06-08 11:58 ` Albert Lee
2005-06-08 13:33 ` Bartlomiej Zolnierkiewicz
2005-06-09 4:05 ` Albert Lee
2005-06-09 6:54 ` Bartlomiej Zolnierkiewicz
2005-06-08 13:39 ` Bartlomiej Zolnierkiewicz
2005-06-06 7:59 ` [PATCH 3/4] trailing data handling " Albert Lee
2005-06-06 9:37 ` Bartlomiej Zolnierkiewicz
2005-06-06 8:01 ` [PATCH 4/4] odd length data handling " Albert Lee
2005-06-06 9:39 ` Bartlomiej Zolnierkiewicz
[not found] ` <42A7ED91.4090008@pobox.com>
2005-06-10 6:08 ` [PATCH 0/4] Resubmit ATAPI PIO mode fixes Albert Lee
2005-06-10 7:38 ` [PATCH 2/4] libata: if condition fix for __atapi_pio_bytes() Albert Lee
2005-06-10 7:56 ` Bartlomiej Zolnierkiewicz
2005-06-10 8:31 ` Albert Lee
2005-06-10 7:44 ` Albert Lee [this message]
2005-06-10 7:46 ` [PATCH 4/4] libata: odd length data handling " Albert Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42A944D4.3030100@tw.ibm.com \
--to=albertcc@tw.ibm.com \
--cc=bzolnier@gmail.com \
--cc=dwm@maxeymade.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).