Re: Pata support for SIS180

[Jeff Garzik <jgarzik@pobox.com>]

Wes Newell wrote:
> Uwe Koziolek wrote:
> 
>> Wes Newell schrieb:
>>
>>  
>>
>>> Can anyone tell me if/how one could add device support for the sis180
>>> chipset pata ports to the sis5513 module? I've tried adding this as
>>> others have said it works for the 965 southbridge,
>>>
>>> if ((trueid == 0x5518) || (trueid == 0x0180)) {
>>>
>>> but it stll doesn't see a real sis180 on a Jetway S755MAX MB.
>>>   
>>
>>
>>
>> you must include the chip into the pci_device_id table
>>
>> static *struct* pci_device_id sis5513_pci_tbl[] = {
>>     { PCI_VENDOR_ID_SI, PCI_DEVICE_ID_SI_5513, PCI_ANY_ID, PCI_ANY_ID, 
>> 0, 0, 0},
>>     { PCI_VENDOR_ID_SI, PCI_DEVICE_ID_SI_5518, PCI_ANY_ID, PCI_ANY_ID, 
>> 0, 0, 0},
>> +    { PCI_VENDOR_ID_SI, PCI_DEVICE_ID_SI_180, PCI_ANY_ID, PCI_ANY_ID, 
>> 0, 0, 0},
>>     { 0, },
>> };
>>
>>
>> regards
>> Uwe Koziolek
>>
>>  
>>
> Won't compile. I copied the sis180 line above into the code (- the + 
> sign of course). I tried both 0x180 and 0x0180 as a trueid. Didn't 
> matter. Keep in mind I'm not a C programmer.:-)
> 
> This is the error I get;
> 
>  CC      drivers/ide/pci/sis5513.o
> drivers/ide/pci/sis5513.c:955: error: `PCI_DEVICE_ID_SI_180' undeclared 
> here (not in a function)

You need to add this #define to include/linux/pci_ids.h.

	Jeff