From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: axboe@suse.de, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata-dev-2.6-ncq: do ata_qc_new inside host_set lock
Date: Sun, 26 Jun 2005 13:25:08 -0400 [thread overview]
Message-ID: <42BEE4F4.90901@pobox.com> (raw)
In-Reply-To: <20050626143623.GC24968@htj.dyndns.org>
Tejun Heo wrote:
> Hello, Jeff.
> Hello, Jens.
>
> This is the third of six misc updates to ncq.
>
> ata_qc_new() used to use atomic test_and_set_bit() to allocate qc.
> This makes grabbing host_set lock before calling ata_qc_new_init()
> unncessary, but in most cases (normal SCSI requests) we're holding the
> lock on entry anyway, so the optimization just adds expensive atomic
> bitops. This patch makes qc allocation performed inside host_set lock
> and uses ffz() instead of atomic bitops.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
hmmmm, I rather liked the old way. I'll give this one some thought.
prev parent reply other threads:[~2005-06-26 17:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-26 14:36 [PATCH] libata-dev-2.6-ncq: do ata_qc_new inside host_set lock Tejun Heo
2005-06-26 17:25 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42BEE4F4.90901@pobox.com \
--to=jgarzik@pobox.com \
--cc=axboe@suse.de \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).