Re: [PATCH Linux 2.6.12 00/09] NCQ: generic NCQ completion/error-handling

[Tejun Heo <htejun@gmail.com>]

Jens Axboe wrote:
> On Mon, Jun 27 2005, Jens Axboe wrote:
> 
>>On Mon, Jun 27 2005, Tejun Heo wrote:
>>
>>> Hello, Jeff.
>>> Hello, Jens.
>>>
>>> This patchset implements generic completion and error-handling for
>>>NCQ commands.  This patchset assumes that the previous six misc
>>>patches to NCQ are applied.
>>
>>Excellent, much needed work in that area. I will give it a test spin
>>here as well, I have one drive that likes to barf with ncq occasionally.
> 
> 
> Ok, I've run with this for a few days and finally hit the
> drive-stops-responding condition yesterday afternoon. Error recovery
> worked a lot better than before, but eventually went down anyways. But
> now I got a better look at the error, and it's the drive throwing an
> ICRC (error 0x80). Very odd. I've never seen this happen with non-NCQ
> operations, however I've seen it now a few times using NCQ. Any ideas?
> 

  Hello, Jens.

  Can you please describe how the drive went down in detail?  If 
possible, log messages w/ the debug message patch applied would be 
great.  As the EH now resets both the controller (on entry to EH) and 
the drive (on timeout), we should be able to recover unless something 
goes very strange.

  I'm currently trying to rewrite sil24 driver to make it look saner and 
support NCQ.  Once I'm done with it (maybe one or two more days... I 
hope), I'll do the second take of generic NCQ patches including ATAPI EH 
fix and stuff and it would be great to have your failure log message 
before doing that.

  Thanks.  :-)

-- 
tejun